Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-30 Thread Namhyung Kim
Hi Masami, On Mon, 29 Sep 2014 20:40:51 +0900, Masami Hiramatsu wrote: > (2014/09/26 23:46), Namhyung Kim wrote: >> The perf should be built with no extra dependencies (other than libc). >> It won't provide rich features but basic functionality (record, report, >> stat) should be supported. And

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-30 Thread Namhyung Kim
Hi Masami, On Mon, 29 Sep 2014 20:40:51 +0900, Masami Hiramatsu wrote: (2014/09/26 23:46), Namhyung Kim wrote: The perf should be built with no extra dependencies (other than libc). It won't provide rich features but basic functionality (record, report, stat) should be supported. And I'm

Re: Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-29 Thread Masami Hiramatsu
(2014/09/26 23:46), Namhyung Kim wrote: > Hi Masami, > > 2014-09-26 (금), 20:54 +0900, Masami Hiramatsu: >> (2014/09/26 15:06), Namhyung Kim wrote: >>> Hi Steve, >>> >>> On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan wrote:

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-29 Thread Masami Hiramatsu
(2014/09/26 23:18), Steven Rostedt wrote: > On Fri, 26 Sep 2014 21:04:26 +0900 > Masami Hiramatsu wrote: > > >>> Please go ahead and get them in. The framework might have to wait >>> until 3.19, so there is no need to have it gate test development. >>> We can evolve them as we go. If tests

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-29 Thread Masami Hiramatsu
(2014/09/26 23:18), Steven Rostedt wrote: On Fri, 26 Sep 2014 21:04:26 +0900 Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Please go ahead and get them in. The framework might have to wait until 3.19, so there is no need to have it gate test development. We can evolve them as we

Re: Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-29 Thread Masami Hiramatsu
(2014/09/26 23:46), Namhyung Kim wrote: Hi Masami, 2014-09-26 (금), 20:54 +0900, Masami Hiramatsu: (2014/09/26 15:06), Namhyung Kim wrote: Hi Steve, On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan shua...@osg.samsung.com wrote: I

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Namhyung Kim
Hi Masami, 2014-09-26 (금), 20:54 +0900, Masami Hiramatsu: > (2014/09/26 15:06), Namhyung Kim wrote: > > Hi Steve, > > > > On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: > >> On Wed, 24 Sep 2014 10:01:38 -0600 > >> Shuah Khan wrote: > >> > >>> I am working on adding the framework for

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Steven Rostedt
On Fri, 26 Sep 2014 21:04:26 +0900 Masami Hiramatsu wrote: > > Please go ahead and get them in. The framework might have to wait > > until 3.19, so there is no need to have it gate test development. > > We can evolve them as we go. If tests require special, it means that > > they aren't

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Steven Rostedt
On Fri, 26 Sep 2014 15:06:51 +0900 Namhyung Kim wrote: > Yeah, and I think we can at least build perf (if not found) for test as > we can always have the source. The trace-cmd is different and it'd be > another reason I need to work on 'perf ftrace' command soon. ;-) Well, if a tool is not

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Masami Hiramatsu
(2014/09/25 1:36), Shuah Khan wrote: > On 09/24/2014 10:30 AM, Steven Rostedt wrote: >> On Wed, 24 Sep 2014 10:22:12 -0600 >> Shuah Khan wrote: >> >> >>> One simple approach is to have the user install the required tools >>> for the test. Indicate what is needed and fail the test with >>>

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Masami Hiramatsu
(2014/09/26 15:06), Namhyung Kim wrote: > Hi Steve, > > On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: >> On Wed, 24 Sep 2014 10:01:38 -0600 >> Shuah Khan wrote: >> >>> I am working on adding the framework for c tests. We will have >>> to get this evolved for shell scripts. Please see

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Namhyung Kim
Hi Steve, On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: > On Wed, 24 Sep 2014 10:01:38 -0600 > Shuah Khan wrote: > >> I am working on adding the framework for c tests. We will have >> to get this evolved for shell scripts. Please see the following >> thread: >> >>

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Namhyung Kim
Hi Steve, On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan shua...@osg.samsung.com wrote: I am working on adding the framework for c tests. We will have to get this evolved for shell scripts. Please see the following thread:

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Masami Hiramatsu
(2014/09/26 15:06), Namhyung Kim wrote: Hi Steve, On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan shua...@osg.samsung.com wrote: I am working on adding the framework for c tests. We will have to get this evolved for shell scripts.

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Masami Hiramatsu
(2014/09/25 1:36), Shuah Khan wrote: On 09/24/2014 10:30 AM, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:22:12 -0600 Shuah Khan shua...@osg.samsung.com wrote: One simple approach is to have the user install the required tools for the test. Indicate what is needed and fail the test with

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Steven Rostedt
On Fri, 26 Sep 2014 15:06:51 +0900 Namhyung Kim namhy...@kernel.org wrote: Yeah, and I think we can at least build perf (if not found) for test as we can always have the source. The trace-cmd is different and it'd be another reason I need to work on 'perf ftrace' command soon. ;-) Well, if

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Steven Rostedt
On Fri, 26 Sep 2014 21:04:26 +0900 Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Please go ahead and get them in. The framework might have to wait until 3.19, so there is no need to have it gate test development. We can evolve them as we go. If tests require special, it means

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-26 Thread Namhyung Kim
Hi Masami, 2014-09-26 (금), 20:54 +0900, Masami Hiramatsu: (2014/09/26 15:06), Namhyung Kim wrote: Hi Steve, On Wed, 24 Sep 2014 12:08:53 -0400, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan shua...@osg.samsung.com wrote: I am working on adding the framework

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Masami Hiramatsu
(2014/09/25 10:14), Steven Rostedt wrote: > On Thu, 25 Sep 2014 09:35:05 +0900 > Masami Hiramatsu wrote: > >> (2014/09/25 0:58), Steven Rostedt wrote: >>> On Wed, 24 Sep 2014 11:42:35 -0400 >>> Steven Rostedt wrote: >>> > I think you'd better use exit_unsupported/exit_xfail to notify >

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Masami Hiramatsu
(2014/09/25 0:42), Steven Rostedt wrote: > On Wed, 24 Sep 2014 11:58:50 +0900 > Masami Hiramatsu wrote: > >> (2014/09/24 6:38), Steven Rostedt wrote: > >>> to them and copied them pretty much unchanged into a ftrace directory >>> under test.d. Is this fine, or is there more massaging I

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Thu, 25 Sep 2014 09:35:05 +0900 Masami Hiramatsu wrote: > (2014/09/25 0:58), Steven Rostedt wrote: > > On Wed, 24 Sep 2014 11:42:35 -0400 > > Steven Rostedt wrote: > > > >>> I think you'd better use exit_unsupported/exit_xfail to notify > >>> that the test target is not configured, or

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Masami Hiramatsu
(2014/09/25 0:58), Steven Rostedt wrote: > On Wed, 24 Sep 2014 11:42:35 -0400 > Steven Rostedt wrote: > >>> I think you'd better use exit_unsupported/exit_xfail to notify >>> that the test target is not configured, or expected to fail. >> > > Are these functions defined anywhere? I don't seem

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Shuah Khan
On 09/24/2014 10:30 AM, Steven Rostedt wrote: > On Wed, 24 Sep 2014 10:22:12 -0600 > Shuah Khan wrote: > > >> One simple approach is to have the user install the required tools >> for the test. Indicate what is needed and fail the test with >> appropriate message with xskip. This is what I have

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 10:22:12 -0600 Shuah Khan wrote: > One simple approach is to have the user install the required tools > for the test. Indicate what is needed and fail the test with > appropriate message with xskip. This is what I have in mind for > tests that can't be run because of a

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Shuah Khan
On 09/24/2014 10:08 AM, Steven Rostedt wrote: > On Wed, 24 Sep 2014 10:01:38 -0600 > Shuah Khan wrote: > >> I am working on adding the framework for c tests. We will have >> to get this evolved for shell scripts. Please see the following >> thread: >> >> https://lkml.org/lkml/2014/9/23/926 >> >

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan wrote: > I am working on adding the framework for c tests. We will have > to get this evolved for shell scripts. Please see the following > thread: > > https://lkml.org/lkml/2014/9/23/926 > Thanks, Also, what's the rules for a test that requires

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Shuah Khan
On 09/24/2014 09:58 AM, Steven Rostedt wrote: > On Wed, 24 Sep 2014 11:42:35 -0400 > Steven Rostedt wrote: > >>> I think you'd better use exit_unsupported/exit_xfail to notify >>> that the test target is not configured, or expected to fail. >> > > Are these functions defined anywhere? I don't

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 11:42:35 -0400 Steven Rostedt wrote: > > I think you'd better use exit_unsupported/exit_xfail to notify > > that the test target is not configured, or expected to fail. > Are these functions defined anywhere? I don't seem them in your v5 patch set, or in selftests anywhere.

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 11:58:50 +0900 Masami Hiramatsu wrote: > (2014/09/24 6:38), Steven Rostedt wrote: > > to them and copied them pretty much unchanged into a ftrace directory > > under test.d. Is this fine, or is there more massaging I need to do > > to them? > > Yeah, ftrace has a

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 11:58:50 +0900 Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2014/09/24 6:38), Steven Rostedt wrote: to them and copied them pretty much unchanged into a ftrace directory under test.d. Is this fine, or is there more massaging I need to do to them?

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 11:42:35 -0400 Steven Rostedt rost...@goodmis.org wrote: I think you'd better use exit_unsupported/exit_xfail to notify that the test target is not configured, or expected to fail. Are these functions defined anywhere? I don't seem them in your v5 patch set, or in

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Shuah Khan
On 09/24/2014 09:58 AM, Steven Rostedt wrote: On Wed, 24 Sep 2014 11:42:35 -0400 Steven Rostedt rost...@goodmis.org wrote: I think you'd better use exit_unsupported/exit_xfail to notify that the test target is not configured, or expected to fail. Are these functions defined anywhere? I

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan shua...@osg.samsung.com wrote: I am working on adding the framework for c tests. We will have to get this evolved for shell scripts. Please see the following thread: https://lkml.org/lkml/2014/9/23/926 Thanks, Also, what's the rules for a

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Shuah Khan
On 09/24/2014 10:08 AM, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:01:38 -0600 Shuah Khan shua...@osg.samsung.com wrote: I am working on adding the framework for c tests. We will have to get this evolved for shell scripts. Please see the following thread:

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Wed, 24 Sep 2014 10:22:12 -0600 Shuah Khan shua...@osg.samsung.com wrote: One simple approach is to have the user install the required tools for the test. Indicate what is needed and fail the test with appropriate message with xskip. This is what I have in mind for tests that can't be run

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Shuah Khan
On 09/24/2014 10:30 AM, Steven Rostedt wrote: On Wed, 24 Sep 2014 10:22:12 -0600 Shuah Khan shua...@osg.samsung.com wrote: One simple approach is to have the user install the required tools for the test. Indicate what is needed and fail the test with appropriate message with xskip. This

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Masami Hiramatsu
(2014/09/25 0:58), Steven Rostedt wrote: On Wed, 24 Sep 2014 11:42:35 -0400 Steven Rostedt rost...@goodmis.org wrote: I think you'd better use exit_unsupported/exit_xfail to notify that the test target is not configured, or expected to fail. Are these functions defined anywhere? I don't

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Steven Rostedt
On Thu, 25 Sep 2014 09:35:05 +0900 Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2014/09/25 0:58), Steven Rostedt wrote: On Wed, 24 Sep 2014 11:42:35 -0400 Steven Rostedt rost...@goodmis.org wrote: I think you'd better use exit_unsupported/exit_xfail to notify that the test

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Masami Hiramatsu
(2014/09/25 0:42), Steven Rostedt wrote: On Wed, 24 Sep 2014 11:58:50 +0900 Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2014/09/24 6:38), Steven Rostedt wrote: to them and copied them pretty much unchanged into a ftrace directory under test.d. Is this fine, or is there

Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-24 Thread Masami Hiramatsu
(2014/09/25 10:14), Steven Rostedt wrote: On Thu, 25 Sep 2014 09:35:05 +0900 Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2014/09/25 0:58), Steven Rostedt wrote: On Wed, 24 Sep 2014 11:42:35 -0400 Steven Rostedt rost...@goodmis.org wrote: I think you'd better use

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-23 Thread Masami Hiramatsu
(2014/09/24 6:38), Steven Rostedt wrote: > > [ > Masami, I took two of my test scripts and added some basic comments Thanks! > to them and copied them pretty much unchanged into a ftrace directory > under test.d. Is this fine, or is there more massaging I need to do > to them? Yeah,

[RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-23 Thread Steven Rostedt
[ Masami, I took two of my test scripts and added some basic comments to them and copied them pretty much unchanged into a ftrace directory under test.d. Is this fine, or is there more massaging I need to do to them? I know the echos don't show up, but I kept them anyway. What should

[RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-23 Thread Steven Rostedt
[ Masami, I took two of my test scripts and added some basic comments to them and copied them pretty much unchanged into a ftrace directory under test.d. Is this fine, or is there more massaging I need to do to them? I know the echos don't show up, but I kept them anyway. What should

Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

2014-09-23 Thread Masami Hiramatsu
(2014/09/24 6:38), Steven Rostedt wrote: [ Masami, I took two of my test scripts and added some basic comments Thanks! to them and copied them pretty much unchanged into a ftrace directory under test.d. Is this fine, or is there more massaging I need to do to them? Yeah, ftrace