Re: [RFC][PATCH 0/3] exec: Moving unshare_files_struct

2018-09-18 Thread Eric W. Biederman
Oleg Nesterov writes: > On 09/16, Eric W. Biederman wrote: >> >> Oleg's patch to remove get_files_struct from proc means we don't need >> two counts in files_struct. > > So it seems you agree with this patch at least in general. I do I think in the context we are looking at things finding a way

Re: [RFC][PATCH 0/3] exec: Moving unshare_files_struct

2018-09-17 Thread Jeff Layton
On Sun, 2018-09-16 at 19:38 +0200, Eric W. Biederman wrote: > Paired with Oleg's patch to reduce the number of callers of > get_files_struct it looks like we can simplify the basic idea of moving > unshare_files in exec by quite a bit so that in net we have fewer lines > of code. > > The big simpl

Re: [RFC][PATCH 0/3] exec: Moving unshare_files_struct

2018-09-17 Thread Oleg Nesterov
On 09/16, Eric W. Biederman wrote: > > Oleg's patch to remove get_files_struct from proc means we don't need > two counts in files_struct. So it seems you agree with this patch at least in general. OK, if nobody else objects I'll split this patch and send the series tomorrow. > Eric W. Biederman

[RFC][PATCH 0/3] exec: Moving unshare_files_struct

2018-09-16 Thread Eric W. Biederman
Paired with Oleg's patch to reduce the number of callers of get_files_struct it looks like we can simplify the basic idea of moving unshare_files in exec by quite a bit so that in net we have fewer lines of code. The big simplification from Jeff's verion is that we take advantage of calling unsh