Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-26 Thread Casey Schaufler
On 7/25/2018 6:18 PM, Ian Kent wrote: > On Wed, 2018-07-25 at 08:48 -0700, Casey Schaufler wrote: >> On 7/24/2018 10:39 PM, Ian Kent wrote: >>> On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: On 7/24/2018 9:00 AM, David Howells wrote: > Casey Schaufler wrote: > >>> (1)

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-26 Thread Casey Schaufler
On 7/25/2018 6:18 PM, Ian Kent wrote: > On Wed, 2018-07-25 at 08:48 -0700, Casey Schaufler wrote: >> On 7/24/2018 10:39 PM, Ian Kent wrote: >>> On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: On 7/24/2018 9:00 AM, David Howells wrote: > Casey Schaufler wrote: > >>> (1)

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-25 Thread Ian Kent
On Wed, 2018-07-25 at 08:48 -0700, Casey Schaufler wrote: > On 7/24/2018 10:39 PM, Ian Kent wrote: > > On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: > > > On 7/24/2018 9:00 AM, David Howells wrote: > > > > Casey Schaufler wrote: > > > > > > > > > > (1) Mount topology and

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-25 Thread Ian Kent
On Wed, 2018-07-25 at 08:48 -0700, Casey Schaufler wrote: > On 7/24/2018 10:39 PM, Ian Kent wrote: > > On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: > > > On 7/24/2018 9:00 AM, David Howells wrote: > > > > Casey Schaufler wrote: > > > > > > > > > > (1) Mount topology and

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-25 Thread Casey Schaufler
On 7/24/2018 10:39 PM, Ian Kent wrote: > On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: >> On 7/24/2018 9:00 AM, David Howells wrote: >>> Casey Schaufler wrote: >>> > (1) Mount topology and reconfiguration change events. With the possibility of unprivileged mounting you're

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-25 Thread Casey Schaufler
On 7/24/2018 10:39 PM, Ian Kent wrote: > On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: >> On 7/24/2018 9:00 AM, David Howells wrote: >>> Casey Schaufler wrote: >>> > (1) Mount topology and reconfiguration change events. With the possibility of unprivileged mounting you're

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread Ian Kent
On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: > On 7/24/2018 9:00 AM, David Howells wrote: > > Casey Schaufler wrote: > > > > > > (1) Mount topology and reconfiguration change events. > > > > > > With the possibility of unprivileged mounting you're going to have to > > > address

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread Ian Kent
On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: > On 7/24/2018 9:00 AM, David Howells wrote: > > Casey Schaufler wrote: > > > > > > (1) Mount topology and reconfiguration change events. > > > > > > With the possibility of unprivileged mounting you're going to have to > > > address

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread David Howells
Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. > >> With the possibility of unprivileged mounting you're going to have to > >> address access control on events. If root in a user namespace mounts a > >> filesystem you may have a case where the "real" user

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread David Howells
Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. > >> With the possibility of unprivileged mounting you're going to have to > >> address access control on events. If root in a user namespace mounts a > >> filesystem you may have a case where the "real" user

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread Casey Schaufler
On 7/24/2018 9:00 AM, David Howells wrote: > Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. >> With the possibility of unprivileged mounting you're going to have to >> address access control on events. If root in a user namespace mounts a >> filesystem you

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread Casey Schaufler
On 7/24/2018 9:00 AM, David Howells wrote: > Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. >> With the possibility of unprivileged mounting you're going to have to >> address access control on events. If root in a user namespace mounts a >> filesystem you

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread David Howells
Casey Schaufler wrote: > > (1) Mount topology and reconfiguration change events. > > With the possibility of unprivileged mounting you're going to have to > address access control on events. If root in a user namespace mounts a > filesystem you may have a case where the "real" user wouldn't

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread David Howells
Casey Schaufler wrote: > > (1) Mount topology and reconfiguration change events. > > With the possibility of unprivileged mounting you're going to have to > address access control on events. If root in a user namespace mounts a > filesystem you may have a case where the "real" user wouldn't

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread Ian Kent
On Mon, 2018-07-23 at 09:31 -0700, Casey Schaufler wrote: > On 7/23/2018 8:25 AM, David Howells wrote: > > Hi Al, > > > > Here's a set of patches to add a general variable-length notification queue > > concept and to add sources of events for: > > Overall I approve. The interface is a bit

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread Ian Kent
On Mon, 2018-07-23 at 09:31 -0700, Casey Schaufler wrote: > On 7/23/2018 8:25 AM, David Howells wrote: > > Hi Al, > > > > Here's a set of patches to add a general variable-length notification queue > > concept and to add sources of events for: > > Overall I approve. The interface is a bit

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread Casey Schaufler
On 7/23/2018 8:25 AM, David Howells wrote: > Hi Al, > > Here's a set of patches to add a general variable-length notification queue > concept and to add sources of events for: Overall I approve. The interface is a bit clunky. Some concerns below. > > (1) Mount topology and reconfiguration

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread Casey Schaufler
On 7/23/2018 8:25 AM, David Howells wrote: > Hi Al, > > Here's a set of patches to add a general variable-length notification queue > concept and to add sources of events for: Overall I approve. The interface is a bit clunky. Some concerns below. > > (1) Mount topology and reconfiguration

[RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread David Howells
Hi Al, Here's a set of patches to add a general variable-length notification queue concept and to add sources of events for: (1) Mount topology and reconfiguration change events. (2) Superblocks EIO, ENOSPC and EDQUOT events (not complete yet). (3) Key/keyring changes events One of the

[RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread David Howells
Hi Al, Here's a set of patches to add a general variable-length notification queue concept and to add sources of events for: (1) Mount topology and reconfiguration change events. (2) Superblocks EIO, ENOSPC and EDQUOT events (not complete yet). (3) Key/keyring changes events One of the