Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread Djalal Harouni
On Wed, May 3, 2017 at 6:04 PM, David Howells wrote: > > Here are a set of patches to create a mount context prior to setting up a > new mount, populating it with the parsed options/binary data and then > effecting the mount. > > This allows namespaces and other information

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread Djalal Harouni
On Wed, May 3, 2017 at 6:04 PM, David Howells wrote: > > Here are a set of patches to create a mount context prior to setting up a > new mount, populating it with the parsed options/binary data and then > effecting the mount. > > This allows namespaces and other information to be conveyed through

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread Miklos Szeredi
On Mon, May 8, 2017 at 10:35 AM, David Howells wrote: >> Further, once you've created a superblock, what are you going to do with it >> other than mount it? I suppose you could statfs it and we could add other >> superblock manipulation functions, but this is normally done

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread Miklos Szeredi
On Mon, May 8, 2017 at 10:35 AM, David Howells wrote: >> Further, once you've created a superblock, what are you going to do with it >> other than mount it? I suppose you could statfs it and we could add other >> superblock manipulation functions, but this is normally done by opening the >>

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread David Howells
David Howells wrote: > > This patchset achieves this partly, but the separation is far from > > crisp clear... First of all why is fsopen() creating a "mount > > context"? It's suppsed to create a "superblock creation context". > > I've no particular objection to renaming

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread David Howells
David Howells wrote: > > This patchset achieves this partly, but the separation is far from > > crisp clear... First of all why is fsopen() creating a "mount > > context"? It's suppsed to create a "superblock creation context". > > I've no particular objection to renaming struct mount_context

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread Miklos Szeredi
On Fri, May 5, 2017 at 5:47 PM, David Howells wrote: > Miklos Szeredi wrote: > >> I'd argue with some design decisions here. One of the motivations for >> doing the mount API overhaul is to create clear distinction between >> separate functions like: >>

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-08 Thread Miklos Szeredi
On Fri, May 5, 2017 at 5:47 PM, David Howells wrote: > Miklos Szeredi wrote: > >> I'd argue with some design decisions here. One of the motivations for >> doing the mount API overhaul is to create clear distinction between >> separate functions like: >> >> - creating filesystem instance (aka

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-05 Thread David Howells
Miklos Szeredi wrote: > I'd argue with some design decisions here. One of the motivations for > doing the mount API overhaul is to create clear distinction between > separate functions like: > > - creating filesystem instance (aka superblock) > > - attaching filesystem

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-05 Thread David Howells
Miklos Szeredi wrote: > I'd argue with some design decisions here. One of the motivations for > doing the mount API overhaul is to create clear distinction between > separate functions like: > > - creating filesystem instance (aka superblock) > > - attaching filesystem instance into mount

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-05 Thread Miklos Szeredi
On Wed, May 3, 2017 at 6:04 PM, David Howells wrote: > > Here are a set of patches to create a mount context prior to setting up a > new mount, populating it with the parsed options/binary data and then > effecting the mount. Great work, thanks for taking this on. I'd argue

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-05 Thread Miklos Szeredi
On Wed, May 3, 2017 at 6:04 PM, David Howells wrote: > > Here are a set of patches to create a mount context prior to setting up a > new mount, populating it with the parsed options/binary data and then > effecting the mount. Great work, thanks for taking this on. I'd argue with some design

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread Jeff Layton
On Wed, 2017-05-03 at 17:50 +0100, David Howells wrote: > Jeff Layton wrote: > > > > (*) Move the walk-from-root stuff that nfs has to generic code so that > > > you > > > can do something akin to: > > > > > > mount /dev/sda1:/foo/bar /mnt > > > > > > See

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread Jeff Layton
On Wed, 2017-05-03 at 17:50 +0100, David Howells wrote: > Jeff Layton wrote: > > > > (*) Move the walk-from-root stuff that nfs has to generic code so that > > > you > > > can do something akin to: > > > > > > mount /dev/sda1:/foo/bar /mnt > > > > > > See nfs_follow_remote_path()

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread David Howells
Jeff Layton wrote: > > (*) Move the walk-from-root stuff that nfs has to generic code so that you > > can do something akin to: > > > > mount /dev/sda1:/foo/bar /mnt > > > > See nfs_follow_remote_path() and mount_subtree(). This is slightly > >

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread David Howells
Jeff Layton wrote: > > (*) Move the walk-from-root stuff that nfs has to generic code so that you > > can do something akin to: > > > > mount /dev/sda1:/foo/bar /mnt > > > > See nfs_follow_remote_path() and mount_subtree(). This is slightly > > tricky in NFS as we have to

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread Jeff Layton
On Wed, 2017-05-03 at 17:04 +0100, David Howells wrote: > Here are a set of patches to create a mount context prior to setting up a > new mount, populating it with the parsed options/binary data and then > effecting the mount. > > This allows namespaces and other information to be conveyed

Re: [RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread Jeff Layton
On Wed, 2017-05-03 at 17:04 +0100, David Howells wrote: > Here are a set of patches to create a mount context prior to setting up a > new mount, populating it with the parsed options/binary data and then > effecting the mount. > > This allows namespaces and other information to be conveyed

[RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread David Howells
Here are a set of patches to create a mount context prior to setting up a new mount, populating it with the parsed options/binary data and then effecting the mount. This allows namespaces and other information to be conveyed through the mount procedure. It also allows extra error information to

[RFC][PATCH 0/9] VFS: Introduce mount context

2017-05-03 Thread David Howells
Here are a set of patches to create a mount context prior to setting up a new mount, populating it with the parsed options/binary data and then effecting the mount. This allows namespaces and other information to be conveyed through the mount procedure. It also allows extra error information to