Re: [RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 12:25:23 +0100 Petr Mladek wrote: > > @@ -193,7 +184,6 @@ int ftrace_raw_output_prep(struct trace_iterator *iter, > > struct trace_seq *s = >seq; > > struct trace_seq *p = >tmp_seq; > > struct trace_entry *entry; > > - int ret; > > > > event =

Re: [RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 12:25:23 +0100 Petr Mladek wrote: > On Thu 2014-11-13 20:12:46, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Adding a trace_seq_has_overflowed() which returns true if the trace_seq > > had too much written into it allows us to simplify the code. > > >

Re: [RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-14 Thread Petr Mladek
On Thu 2014-11-13 20:12:46, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Adding a trace_seq_has_overflowed() which returns true if the trace_seq > had too much written into it allows us to simplify the code. > > Instead of checking the return value of every call to

Re: [RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-14 Thread Petr Mladek
On Thu 2014-11-13 20:12:46, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Adding a trace_seq_has_overflowed() which returns true if the trace_seq had too much written into it allows us to simplify the code. Instead of checking the return value of every call to

Re: [RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 12:25:23 +0100 Petr Mladek pmla...@suse.cz wrote: On Thu 2014-11-13 20:12:46, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Adding a trace_seq_has_overflowed() which returns true if the trace_seq had too much written into it allows us to

Re: [RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 12:25:23 +0100 Petr Mladek pmla...@suse.cz wrote: @@ -193,7 +184,6 @@ int ftrace_raw_output_prep(struct trace_iterator *iter, struct trace_seq *s = iter-seq; struct trace_seq *p = iter-tmp_seq; struct trace_entry *entry; - int ret; event =

[RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-13 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Adding a trace_seq_has_overflowed() which returns true if the trace_seq had too much written into it allows us to simplify the code. Instead of checking the return value of every call to trace_seq_printf() and friends, they can all be called normally, and at the

[RFC][PATCH 02/23 v4] tracing: Add trace_seq_has_overflowed() and trace_handle_return()

2014-11-13 Thread Steven Rostedt
From: Steven Rostedt (Red Hat) rost...@goodmis.org Adding a trace_seq_has_overflowed() which returns true if the trace_seq had too much written into it allows us to simplify the code. Instead of checking the return value of every call to trace_seq_printf() and friends, they can all be called