Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-26 Thread Steven Rostedt
On Mon, 26 Nov 2018 20:30:49 +0900 Masami Hiramatsu wrote: > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > index f98063e273e5..477ff9412d26 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -749,6 +749,18 @@ typedef int

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-26 Thread Steven Rostedt
On Mon, 26 Nov 2018 20:30:49 +0900 Masami Hiramatsu wrote: > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > index f98063e273e5..477ff9412d26 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -749,6 +749,18 @@ typedef int

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-26 Thread Masami Hiramatsu
On Wed, 21 Nov 2018 20:27:15 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Currently the registering of function graph is to pass in a entry and return > function. We need to have a way to associate those functions together where > the entry can determine to run the return

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-26 Thread Masami Hiramatsu
On Wed, 21 Nov 2018 20:27:15 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Currently the registering of function graph is to pass in a entry and return > function. We need to have a way to associate those functions together where > the entry can determine to run the return

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-23 Thread Steven Rostedt
On Thu, 22 Nov 2018 18:59:46 -0800 Joel Fernandes wrote: > > static struct ftrace_ops ftrace_profile_ops __read_mostly = { > > diff --git a/kernel/trace/trace_functions_graph.c > > b/kernel/trace/trace_functions_graph.c > > index 0e0ff08357cf..7c7fd13d2373 100644 > > ---

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-23 Thread Steven Rostedt
On Thu, 22 Nov 2018 18:59:46 -0800 Joel Fernandes wrote: > > static struct ftrace_ops ftrace_profile_ops __read_mostly = { > > diff --git a/kernel/trace/trace_functions_graph.c > > b/kernel/trace/trace_functions_graph.c > > index 0e0ff08357cf..7c7fd13d2373 100644 > > ---

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-22 Thread Joel Fernandes
On Wed, Nov 21, 2018 at 08:27:15PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Currently the registering of function graph is to pass in a entry and return > function. We need to have a way to associate those functions together where > the entry can determine to run the

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-22 Thread Joel Fernandes
On Wed, Nov 21, 2018 at 08:27:15PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Currently the registering of function graph is to pass in a entry and return > function. We need to have a way to associate those functions together where > the entry can determine to run the

[RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-21 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Currently the registering of function graph is to pass in a entry and return function. We need to have a way to associate those functions together where the entry can determine to run the return hook. Having a structure that contains both functions will facilitate

[RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-21 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Currently the registering of function graph is to pass in a entry and return function. We need to have a way to associate those functions together where the entry can determine to run the return hook. Having a structure that contains both functions will facilitate