Re: [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru

2014-01-15 Thread Kirill A. Shutemov
On Tue, Jan 14, 2014 at 10:00:44AM -0800, Dave Hansen wrote: > > From: Dave Hansen > > 'struct page' has two list_head fields: 'lru' and 'list'. > Conveniently, they are unioned together. This means that code > can use them interchangably, which gets horribly confusing like > with this nugget

Re: [RFC][PATCH 1/9] mm: slab/slub: use page-list consistently instead of page-lru

2014-01-15 Thread Kirill A. Shutemov
On Tue, Jan 14, 2014 at 10:00:44AM -0800, Dave Hansen wrote: From: Dave Hansen dave.han...@linux.intel.com 'struct page' has two list_head fields: 'lru' and 'list'. Conveniently, they are unioned together. This means that code can use them interchangably, which gets horribly confusing

Re: [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru

2014-01-14 Thread David Rientjes
On Tue, 14 Jan 2014, Dave Hansen wrote: > > block/blk-mq.c: In function ‘blk_mq_free_rq_map’: > > block/blk-mq.c:1094:10: error: ‘struct page’ has no member named ‘list’ > > block/blk-mq.c:1094:10: warning: initialization from incompatible pointer > > type [enabled by default] > >

Re: [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru

2014-01-14 Thread Dave Hansen
On 01/14/2014 06:31 PM, David Rientjes wrote: > Did you try with a CONFIG_BLOCK config? > > block/blk-mq.c: In function ‘blk_mq_free_rq_map’: > block/blk-mq.c:1094:10: error: ‘struct page’ has no member named ‘list’ > block/blk-mq.c:1094:10: warning: initialization from incompatible pointer >

Re: [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru

2014-01-14 Thread David Rientjes
On Tue, 14 Jan 2014, Dave Hansen wrote: > diff -puN > include/linux/mm_types.h~make-slab-use-page-lru-vs-list-consistently > include/linux/mm_types.h > --- a/include/linux/mm_types.h~make-slab-use-page-lru-vs-list-consistently > 2014-01-14 09:57:56.099621967 -0800 > +++

Re: [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru

2014-01-14 Thread Christoph Lameter
On Tue, 14 Jan 2014, Dave Hansen wrote: > This patch makes the slab and slub code use page->lru > universally instead of mixing ->list and ->lru. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru

2014-01-14 Thread Dave Hansen
From: Dave Hansen 'struct page' has two list_head fields: 'lru' and 'list'. Conveniently, they are unioned together. This means that code can use them interchangably, which gets horribly confusing like with this nugget from slab.c: > list_del(>lru); > if (page->active ==

[RFC][PATCH 1/9] mm: slab/slub: use page-list consistently instead of page-lru

2014-01-14 Thread Dave Hansen
From: Dave Hansen dave.han...@linux.intel.com 'struct page' has two list_head fields: 'lru' and 'list'. Conveniently, they are unioned together. This means that code can use them interchangably, which gets horribly confusing like with this nugget from slab.c: list_del(page-lru);

Re: [RFC][PATCH 1/9] mm: slab/slub: use page-list consistently instead of page-lru

2014-01-14 Thread Christoph Lameter
On Tue, 14 Jan 2014, Dave Hansen wrote: This patch makes the slab and slub code use page-lru universally instead of mixing -list and -lru. Acked-by: Christoph Lameter c...@linux.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [RFC][PATCH 1/9] mm: slab/slub: use page-list consistently instead of page-lru

2014-01-14 Thread David Rientjes
On Tue, 14 Jan 2014, Dave Hansen wrote: diff -puN include/linux/mm_types.h~make-slab-use-page-lru-vs-list-consistently include/linux/mm_types.h --- a/include/linux/mm_types.h~make-slab-use-page-lru-vs-list-consistently 2014-01-14 09:57:56.099621967 -0800 +++ b/include/linux/mm_types.h

Re: [RFC][PATCH 1/9] mm: slab/slub: use page-list consistently instead of page-lru

2014-01-14 Thread Dave Hansen
On 01/14/2014 06:31 PM, David Rientjes wrote: Did you try with a CONFIG_BLOCK config? block/blk-mq.c: In function ‘blk_mq_free_rq_map’: block/blk-mq.c:1094:10: error: ‘struct page’ has no member named ‘list’ block/blk-mq.c:1094:10: warning: initialization from incompatible pointer type

Re: [RFC][PATCH 1/9] mm: slab/slub: use page-list consistently instead of page-lru

2014-01-14 Thread David Rientjes
On Tue, 14 Jan 2014, Dave Hansen wrote: block/blk-mq.c: In function ‘blk_mq_free_rq_map’: block/blk-mq.c:1094:10: error: ‘struct page’ has no member named ‘list’ block/blk-mq.c:1094:10: warning: initialization from incompatible pointer type [enabled by default] block/blk-mq.c:1094:10: