Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-18 Thread Arjan van de Ven
We should be able to boil it down to a sequence on ARM as well. But it means dropping cpufreq and looking at the clock framework. Are you still using the pre- and post-change notifiers on Intel, or can they be ignored safely? we do not use change notifiers (since the hardware changes

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-18 Thread Morten Rasmussen
On Thu, Oct 17, 2013 at 06:18:38PM +0100, Arjan van de Ven wrote: > >> > >> cpufreq has pre- and post-change notifiers so the current TC2 clock driver > > yeah those are EVIL ;-) > > >> waits (yields) in its clk_set_rate() implementation until the change has > >> happened to ensure that the

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-18 Thread Morten Rasmussen
On Thu, Oct 17, 2013 at 05:54:16PM +0100, Peter Zijlstra wrote: > On Thu, Oct 17, 2013 at 05:40:38PM +0100, Morten Rasmussen wrote: > > On Mon, Oct 14, 2013 at 04:14:25PM +0100, Arjan van de Ven wrote: > > > On 10/14/2013 6:33 AM, Peter Zijlstra wrote: > > > > On Fri, Oct 11, 2013 at 06:19:14PM

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-18 Thread Morten Rasmussen
On Thu, Oct 17, 2013 at 05:54:16PM +0100, Peter Zijlstra wrote: On Thu, Oct 17, 2013 at 05:40:38PM +0100, Morten Rasmussen wrote: On Mon, Oct 14, 2013 at 04:14:25PM +0100, Arjan van de Ven wrote: On 10/14/2013 6:33 AM, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100,

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-18 Thread Morten Rasmussen
On Thu, Oct 17, 2013 at 06:18:38PM +0100, Arjan van de Ven wrote: cpufreq has pre- and post-change notifiers so the current TC2 clock driver yeah those are EVIL ;-) waits (yields) in its clk_set_rate() implementation until the change has happened to ensure that the post-change

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-18 Thread Arjan van de Ven
We should be able to boil it down to a sequence on ARM as well. But it means dropping cpufreq and looking at the clock framework. Are you still using the pre- and post-change notifiers on Intel, or can they be ignored safely? we do not use change notifiers (since the hardware changes

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-17 Thread Arjan van de Ven
cpufreq has pre- and post-change notifiers so the current TC2 clock driver yeah those are EVIL ;-) waits (yields) in its clk_set_rate() implementation until the change has happened to ensure that the post-change notifier happens at the right time. Since clk_set_rate() is allowed to sleep

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-17 Thread Peter Zijlstra
On Thu, Oct 17, 2013 at 05:40:38PM +0100, Morten Rasmussen wrote: > On Mon, Oct 14, 2013 at 04:14:25PM +0100, Arjan van de Ven wrote: > > On 10/14/2013 6:33 AM, Peter Zijlstra wrote: > > > On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: > > >> Removing power hints for kworker

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-17 Thread Morten Rasmussen
On Mon, Oct 14, 2013 at 04:14:25PM +0100, Arjan van de Ven wrote: > On 10/14/2013 6:33 AM, Peter Zijlstra wrote: > > On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: > >> Removing power hints for kworker threads enables easier use of > >> workqueues in the power driver late

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-17 Thread Morten Rasmussen
On Mon, Oct 14, 2013 at 04:14:25PM +0100, Arjan van de Ven wrote: On 10/14/2013 6:33 AM, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-17 Thread Peter Zijlstra
On Thu, Oct 17, 2013 at 05:40:38PM +0100, Morten Rasmussen wrote: On Mon, Oct 14, 2013 at 04:14:25PM +0100, Arjan van de Ven wrote: On 10/14/2013 6:33 AM, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-17 Thread Arjan van de Ven
cpufreq has pre- and post-change notifiers so the current TC2 clock driver yeah those are EVIL ;-) waits (yields) in its clk_set_rate() implementation until the change has happened to ensure that the post-change notifier happens at the right time. Since clk_set_rate() is allowed to sleep

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Morten Rasmussen
On Mon, Oct 14, 2013 at 05:13:11PM +0100, Arjan van de Ven wrote: > On 10/14/2013 9:10 AM, Morten Rasmussen wrote: > > On Mon, Oct 14, 2013 at 02:33:56PM +0100, Peter Zijlstra wrote: > >> On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: > >>> Removing power hints for kworker

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Arjan van de Ven
On 10/14/2013 9:10 AM, Morten Rasmussen wrote: On Mon, Oct 14, 2013 at 02:33:56PM +0100, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Morten Rasmussen
On Mon, Oct 14, 2013 at 02:33:56PM +0100, Peter Zijlstra wrote: > On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: > > Removing power hints for kworker threads enables easier use of > > workqueues in the power driver late callback. That would otherwise > > lead to an endless loop

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Arjan van de Ven
On 10/14/2013 6:33 AM, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That would otherwise lead to an endless loop unless it is prevented in the

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Peter Zijlstra
On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: > Removing power hints for kworker threads enables easier use of > workqueues in the power driver late callback. That would otherwise > lead to an endless loop unless it is prevented in the power driver. There's many kworker users;

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Peter Zijlstra
On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That would otherwise lead to an endless loop unless it is prevented in the power driver. There's many kworker users;

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Arjan van de Ven
On 10/14/2013 6:33 AM, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That would otherwise lead to an endless loop unless it is prevented in the

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Morten Rasmussen
On Mon, Oct 14, 2013 at 02:33:56PM +0100, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That would otherwise lead to an endless loop unless

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Arjan van de Ven
On 10/14/2013 9:10 AM, Morten Rasmussen wrote: On Mon, Oct 14, 2013 at 02:33:56PM +0100, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That

Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-14 Thread Morten Rasmussen
On Mon, Oct 14, 2013 at 05:13:11PM +0100, Arjan van de Ven wrote: On 10/14/2013 9:10 AM, Morten Rasmussen wrote: On Mon, Oct 14, 2013 at 02:33:56PM +0100, Peter Zijlstra wrote: On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote: Removing power hints for kworker threads enables

[RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-11 Thread Morten Rasmussen
Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That would otherwise lead to an endless loop unless it is prevented in the power driver. Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 20 +--- 1 file

[RFC][PATCH 4/7] sched: power: Remove power capacity hints for kworker threads

2013-10-11 Thread Morten Rasmussen
Removing power hints for kworker threads enables easier use of workqueues in the power driver late callback. That would otherwise lead to an endless loop unless it is prevented in the power driver. Signed-off-by: Morten Rasmussen morten.rasmus...@arm.com --- kernel/sched/fair.c | 20