Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-19 Thread Mark Brown
On Tue, Jul 19, 2016 at 02:59:31PM -0700, John Stultz wrote: > Then the probe/remove logic to register the codec, and connected it up > with the simple card driver. > Though it seems kind of silly to have a whole driver (and devicetree > entry for the probe hook) just to fill and install the

Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-19 Thread Mark Brown
On Tue, Jul 19, 2016 at 02:59:31PM -0700, John Stultz wrote: > Then the probe/remove logic to register the codec, and connected it up > with the simple card driver. > Though it seems kind of silly to have a whole driver (and devicetree > entry for the probe hook) just to fill and install the

Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-19 Thread John Stultz
On Sat, Jul 16, 2016 at 4:44 AM, Mark Brown wrote: > On Fri, Jul 15, 2016 at 07:13:26PM -0700, John Stultz wrote: >> >> + .cpu_dai_name = "f7118000.hi6210_i2s", > > Why is this not connected up in DT - as things stand the card has zero > reuse potential. Though given that

Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-19 Thread John Stultz
On Sat, Jul 16, 2016 at 4:44 AM, Mark Brown wrote: > On Fri, Jul 15, 2016 at 07:13:26PM -0700, John Stultz wrote: >> >> + .cpu_dai_name = "f7118000.hi6210_i2s", > > Why is this not connected up in DT - as things stand the card has zero > reuse potential. Though given that this has > >> +

Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-16 Thread Mark Brown
On Fri, Jul 15, 2016 at 07:13:26PM -0700, John Stultz wrote: > sound/soc/Kconfig | 1 + > sound/soc/Makefile | 1 + > sound/soc/hisilicon/Kconfig| 5 + > sound/soc/hisilicon/Makefile | 2 + >

Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-16 Thread Mark Brown
On Fri, Jul 15, 2016 at 07:13:26PM -0700, John Stultz wrote: > sound/soc/Kconfig | 1 + > sound/soc/Makefile | 1 + > sound/soc/hisilicon/Kconfig| 5 + > sound/soc/hisilicon/Makefile | 2 + >

[RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-15 Thread John Stultz
From: Andy Green Add driver for hi6210 i2s controller found on hi6220 boards. Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod

[RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

2016-07-15 Thread John Stultz
From: Andy Green Add driver for hi6210 i2s controller found on hi6220 boards. Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc: Dan Williams Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Wei Xu Cc: Rob Herring