Re: [RFC][PATCH 6/9] seqlock: Better document raw_write_seqcount_latch()

2015-03-02 Thread Paul E. McKenney
On Mon, Mar 02, 2015 at 09:51:16AM +0100, Peter Zijlstra wrote: > On Mon, Mar 02, 2015 at 09:33:20AM +0100, Peter Zijlstra wrote: > > On Sun, Mar 01, 2015 at 02:02:23PM +, Mathieu Desnoyers wrote: > > > > The latch, AFAIU, takes care of making sure the new objects are > > > initialized before

Re: [RFC][PATCH 6/9] seqlock: Better document raw_write_seqcount_latch()

2015-03-02 Thread Peter Zijlstra
On Mon, Mar 02, 2015 at 09:33:20AM +0100, Peter Zijlstra wrote: > On Sun, Mar 01, 2015 at 02:02:23PM +, Mathieu Desnoyers wrote: > > The latch, AFAIU, takes care of making sure the new objects are > > initialized before being published into the data structure, so there > > would be no need to

Re: [RFC][PATCH 6/9] seqlock: Better document raw_write_seqcount_latch()

2015-03-02 Thread Peter Zijlstra
On Sun, Mar 01, 2015 at 02:02:23PM +, Mathieu Desnoyers wrote: > > + * So during the modification, queries are first redirected to data[1]. > > Then we > > + * modify data[0]. When that is complete, we redirect queries back to > > data[0] > > + * and we can modify data[1]. > > + * > > + * NOT

Re: [RFC][PATCH 6/9] seqlock: Better document raw_write_seqcount_latch()

2015-03-01 Thread Michel Lespinasse
On Sat, Feb 28, 2015 at 1:24 PM, Peter Zijlstra wrote: > Improve the documentation of the latch technique as used in the > current timekeeping code, such that it can be readily employed > elsewhere. > > Borrow from the comments in timekeeping and replace those with a > reference to this more gener

Re: [RFC][PATCH 6/9] seqlock: Better document raw_write_seqcount_latch()

2015-03-01 Thread Mathieu Desnoyers
..@linutronix.de, pet...@infradead.org, > "Michel Lespinasse" , "Andrea Arcangeli" > , "David Woodhouse" > , "Rik van Riel" > Sent: Saturday, February 28, 2015 4:24:53 PM > Subject: [RFC][PATCH 6/9] seqlock: Better document raw_write_se

[RFC][PATCH 6/9] seqlock: Better document raw_write_seqcount_latch()

2015-02-28 Thread Peter Zijlstra
Improve the documentation of the latch technique as used in the current timekeeping code, such that it can be readily employed elsewhere. Borrow from the comments in timekeeping and replace those with a reference to this more generic comment. Cc: Oleg Nesterov Cc: Michel Lespinasse Cc: Andrea A