RE: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-11 Thread Seiji Aguchi
Matt, I submitted a v3 patch based on my comment below.. Seiji > -Original Message- > From: linux-efi-ow...@vger.kernel.org > [mailto:linux-efi-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi > Sent: Wednesday, October 09, 2013 12:37 PM > To: Matt Fleming > Cc:

RE: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-11 Thread Seiji Aguchi
Matt, I submitted a v3 patch based on my comment below.. Seiji -Original Message- From: linux-efi-ow...@vger.kernel.org [mailto:linux-efi-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi Sent: Wednesday, October 09, 2013 12:37 PM To: Matt Fleming Cc: linux-kernel@vger.kernel.org;

RE: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-09 Thread Seiji Aguchi
Thank you for reviewing. In my understanding, your point is that all accesses to efivar_entry should be done while holding __efivars->lock. > > @@ -88,8 +103,9 @@ static int efi_pstore_read_func(struct efivar_entry > > *entry, void *data) > > return 0; > > > >

RE: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-09 Thread Seiji Aguchi
Thank you for reviewing. In my understanding, your point is that all accesses to efivar_entry should be done while holding __efivars-lock. @@ -88,8 +103,9 @@ static int efi_pstore_read_func(struct efivar_entry *entry, void *data) return 0; entry-var.DataSize = 1024;

Re: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-07 Thread Matt Fleming
On Fri, 27 Sep, at 04:23:52PM, Seiji Aguchi wrote: > Change form v1 > - Rebase to 3.12-rc2 > > Currently, when mounting pstore file system, a read callback of efi_pstore > driver runs mutiple times as below. > > - In the first read callback, scan efivar_sysfs_list from head and pass > a kmsg

Re: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-07 Thread Matt Fleming
On Fri, 27 Sep, at 04:23:52PM, Seiji Aguchi wrote: Change form v1 - Rebase to 3.12-rc2 Currently, when mounting pstore file system, a read callback of efi_pstore driver runs mutiple times as below. - In the first read callback, scan efivar_sysfs_list from head and pass a kmsg buffer

Re: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-04 Thread Fleming, Matt
On 4 October 2013 16:46, Seiji Aguchi wrote: > Are there anyone who can review this bugfix? Sorry I haven't got to it yet (or the previous version). It is on my TODO list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

RE: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-04 Thread Seiji Aguchi
Are there anyone who can review this bugfix? Seiji > -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi > Sent: Friday, September 27, 2013 4:24 PM > To: linux-kernel@vger.kernel.org;

RE: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-04 Thread Seiji Aguchi
Are there anyone who can review this bugfix? Seiji -Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi Sent: Friday, September 27, 2013 4:24 PM To: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org;

Re: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-04 Thread Fleming, Matt
On 4 October 2013 16:46, Seiji Aguchi seiji.agu...@hds.com wrote: Are there anyone who can review this bugfix? Sorry I haven't got to it yet (or the previous version). It is on my TODO list. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-09-27 Thread Seiji Aguchi
Change form v1 - Rebase to 3.12-rc2 Currently, when mounting pstore file system, a read callback of efi_pstore driver runs mutiple times as below. - In the first read callback, scan efivar_sysfs_list from head and pass a kmsg buffer of a entry to an upper pstore layer. - In the second read

[RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-09-27 Thread Seiji Aguchi
Change form v1 - Rebase to 3.12-rc2 Currently, when mounting pstore file system, a read callback of efi_pstore driver runs mutiple times as below. - In the first read callback, scan efivar_sysfs_list from head and pass a kmsg buffer of a entry to an upper pstore layer. - In the second read