On Sat, Jun 09, 2018 at 06:10:51AM +0100, Al Viro wrote:
> On Fri, Jun 08, 2018 at 11:57:06AM -0700, Linus Torvalds wrote:
> > I'm obviously biased since I asked for this, but:
> >
> > On Fri, Jun 8, 2018 at 11:48 AM Al Viro wrote:
> > >
> > > 33 files changed, 135 insertions(+), 180
On Sat, Jun 09, 2018 at 06:10:51AM +0100, Al Viro wrote:
> On Fri, Jun 08, 2018 at 11:57:06AM -0700, Linus Torvalds wrote:
> > I'm obviously biased since I asked for this, but:
> >
> > On Fri, Jun 8, 2018 at 11:48 AM Al Viro wrote:
> > >
> > > 33 files changed, 135 insertions(+), 180
On Sat, Jun 09, 2018 at 06:10:51AM +0100, Al Viro wrote:
> That leaves
> * anon_inode_getfile() - converts to similar form, at the price of
> ihold done slightly earlier, so that failure exit needs a (non-final, i.e.
> very cheap) iput() we currently avoid. Not a problem.
> *
On Sat, Jun 09, 2018 at 06:10:51AM +0100, Al Viro wrote:
> That leaves
> * anon_inode_getfile() - converts to similar form, at the price of
> ihold done slightly earlier, so that failure exit needs a (non-final, i.e.
> very cheap) iput() we currently avoid. Not a problem.
> *
On Fri, Jun 08, 2018 at 11:57:06AM -0700, Linus Torvalds wrote:
> I'm obviously biased since I asked for this, but:
>
> On Fri, Jun 8, 2018 at 11:48 AM Al Viro wrote:
> >
> > 33 files changed, 135 insertions(+), 180 deletions(-)
>
> this already looks nice.
>
> I'll go through the individual
On Fri, Jun 08, 2018 at 11:57:06AM -0700, Linus Torvalds wrote:
> I'm obviously biased since I asked for this, but:
>
> On Fri, Jun 8, 2018 at 11:48 AM Al Viro wrote:
> >
> > 33 files changed, 135 insertions(+), 180 deletions(-)
>
> this already looks nice.
>
> I'll go through the individual
I'm obviously biased since I asked for this, but:
On Fri, Jun 8, 2018 at 11:48 AM Al Viro wrote:
>
> 33 files changed, 135 insertions(+), 180 deletions(-)
this already looks nice.
I'll go through the individual patches and see if there's anything
there that raises my hackles. Silence will
I'm obviously biased since I asked for this, but:
On Fri, Jun 8, 2018 at 11:48 AM Al Viro wrote:
>
> 33 files changed, 135 insertions(+), 180 deletions(-)
this already looks nice.
I'll go through the individual patches and see if there's anything
there that raises my hackles. Silence will
->atomic_open() calling conventions are nasty; we have
two bits of state ("has file gotten past ->open()" and "have
we created a new file here") passed by reference, with rather
brittle logics in the callers. In some error cases do_last()
et.al. end up doing a full-blow fput() (and
->atomic_open() calling conventions are nasty; we have
two bits of state ("has file gotten past ->open()" and "have
we created a new file here") passed by reference, with rather
brittle logics in the callers. In some error cases do_last()
et.al. end up doing a full-blow fput() (and
10 matches
Mail list logo
