Re: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-13 Thread Christoph Hellwig
I've pulled v2 with the ia64 into dma-mapping for-next. This should give us a little more than a week in linux-next to sort out any issues.

Re: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-11 Thread Christoph Hellwig
On Tue, Dec 11, 2018 at 05:13:30PM +, Luck, Tony wrote: > > But that might not be your fault. My ancient system is getting flaky. A > > v4.19 build that > > has booted before is also resetting :-( > > After a power-cycle (and some time to let the machine cool off). System now > boots > with

RE: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-11 Thread Luck, Tony
> But that might not be your fault. My ancient system is getting flaky. A v4.19 > build that > has booted before is also resetting :-( After a power-cycle (and some time to let the machine cool off). System now boots with your patch series plus the __phys_to_pfn() #define So if you can figure

RE: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-11 Thread Luck, Tony
> This should fix it: ... > +#include Not quite. Still have an issue with __phys_to_pfn(paddr) Trying ti #include gave we a raft of redefined macros. So I just added #define __phys_to_pfn(paddr)PHYS_PFN(paddr) to arch/ia64/mm/init.c That made the build work. But boot spontaneously

Re: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-10 Thread Christoph Hellwig
On Mon, Dec 10, 2018 at 01:51:13PM -0800, Luck, Tony wrote: > But the ia64 build fails with: Yes, I just got the same complaint form the buildbot, unfortunately I don't have a good ia64 cross compiler locally given that Debian is lacking one, and the one provided by the buildbot doesn't build on

Re: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-10 Thread Luck, Tony
On Fri, Dec 07, 2018 at 11:07:05AM -0800, Christoph Hellwig wrote: > This works is based on the dma-mapping tree, so you probably want to > want this git tree for testing: > > git://git.infradead.org/users/hch/misc.git dma-direct-calls.2 Pulled this tree. Got HEAD 33b9fc015171

Re: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-08 Thread Christoph Hellwig
On Sat, Dec 08, 2018 at 05:06:48PM +0100, Jesper Dangaard Brouer wrote: > You can add my: > Tested-by: Jesper Dangaard Brouer > or > Acked-by: Jesper Dangaard Brouer > > I'm very happy that you work on this. And I've done micro-benchmark > testing of the patchset (and branch

Re: [RFC] avoid indirect calls for DMA direct mappings v2

2018-12-08 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 11:07:05 -0800 Christoph Hellwig wrote: > Hi all, > > a while ago Jesper reported major performance regressions due to the > spectre v2 mitigations in his XDP forwarding workloads. A large part > of that is due to the DMA mapping API indirect calls. > > It turns out that

[RFC] avoid indirect calls for DMA direct mappings v2

2018-12-07 Thread Christoph Hellwig
Hi all, a while ago Jesper reported major performance regressions due to the spectre v2 mitigations in his XDP forwarding workloads. A large part of that is due to the DMA mapping API indirect calls. It turns out that the most common implementation of the DMA API is the direct mapping case, and