Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-05 Thread Stefan Seyfried
Hi, On Thu, Jul 05, 2007 at 12:39:22AM +0200, Pavel Machek wrote: > Hi! > > > Yes, but I'm not sure if netconsole is the only one that we will want to > > have > > Well, netconsole is the only one we know of. AFAIR it is plain luck that serial console sometimes works. I repeat: "no

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-05 Thread Stefan Seyfried
Hi, On Thu, Jul 05, 2007 at 12:39:22AM +0200, Pavel Machek wrote: Hi! Yes, but I'm not sure if netconsole is the only one that we will want to have Well, netconsole is the only one we know of. AFAIR it is plain luck that serial console sometimes works. I repeat: no bugreport is not

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Pavel Machek
Hi! > > > > diff --git a/drivers/char/lp.c b/drivers/char/lp.c > > > > index 62051f8..8267ff8 100644 > > > > --- a/drivers/char/lp.c > > > > +++ b/drivers/char/lp.c > > > > @@ -144,7 +144,7 @@ static unsigned int lp_count = 0; > > > > static struct class *lp_class; > > > > > > > > #ifdef

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Rafael J. Wysocki
On Wednesday, 4 July 2007 21:33, Pavel Machek wrote: > Hi! > > > > What about this? (Only compile tested, but looks pretty obvious to > > > me). Something like this should get us rid of ugly option, and still > > > solve debugging problems... Hmmm? > > >

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Pavel Machek
Hi! > > What about this? (Only compile tested, but looks pretty obvious to > > me). Something like this should get us rid of ugly option, and still > > solve debugging problems... Hmmm? > > Pavel > > > > Kill

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Pavel Machek
Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm? Pavel Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Rafael J. Wysocki
On Wednesday, 4 July 2007 21:33, Pavel Machek wrote: Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-07-04 Thread Pavel Machek
Hi! diff --git a/drivers/char/lp.c b/drivers/char/lp.c index 62051f8..8267ff8 100644 --- a/drivers/char/lp.c +++ b/drivers/char/lp.c @@ -144,7 +144,7 @@ static unsigned int lp_count = 0; static struct class *lp_class; #ifdef CONFIG_LP_CONSOLE -static struct

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-29 Thread Stefan Seyfried
On Thu, Jun 28, 2007 at 09:12:44PM +0200, Rafael J. Wysocki wrote: > On Thursday, 28 June 2007 19:25, Stefan Seyfried wrote: > > > > However, we don't know which consoles are safe to stay alive during suspend. > > Generally, defaulting to suspending them all is not a bad idea IMHO. > > And IIRC

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-29 Thread Stefan Seyfried
On Thu, Jun 28, 2007 at 09:12:44PM +0200, Rafael J. Wysocki wrote: On Thursday, 28 June 2007 19:25, Stefan Seyfried wrote: However, we don't know which consoles are safe to stay alive during suspend. Generally, defaulting to suspending them all is not a bad idea IMHO. And IIRC it is

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Rafael J. Wysocki
On Thursday, 28 June 2007 19:25, Stefan Seyfried wrote: > (CC'ing Linus, since disabling consoles during suspend was his idea IIRC) > > On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote: > > Hi, > > > > On Thursday, 28 June 2007 15:51, Pavel Machek wrote: > > > Hi! > > > > > >

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Stefan Seyfried
(CC'ing Linus, since disabling consoles during suspend was his idea IIRC) On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote: > Hi, > > On Thursday, 28 June 2007 15:51, Pavel Machek wrote: > > Hi! > > > > What about this? (Only compile tested, but looks pretty obvious to > > me).

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Rafael J. Wysocki
Hi, On Thursday, 28 June 2007 15:51, Pavel Machek wrote: > Hi! > > What about this? (Only compile tested, but looks pretty obvious to > me). Something like this should get us rid of ugly option, and still > solve debugging problems... Hmmm? >

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Tejun Heo
Pavel Machek wrote: > Hi! > > What about this? (Only compile tested, but looks pretty obvious to > me). Something like this should get us rid of ugly option, and still > solve debugging problems... Hmmm? Violent agreement from me. Not taking down serial console would help a lot too. Storing

[RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Pavel Machek
Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm? Pavel Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it should not

[RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Pavel Machek
Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm? Pavel Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it should not

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Tejun Heo
Pavel Machek wrote: Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm? Violent agreement from me. Not taking down serial console would help a lot too. Storing dmesg

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Rafael J. Wysocki
Hi, On Thursday, 28 June 2007 15:51, Pavel Machek wrote: Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Stefan Seyfried
(CC'ing Linus, since disabling consoles during suspend was his idea IIRC) On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote: Hi, On Thursday, 28 June 2007 15:51, Pavel Machek wrote: Hi! What about this? (Only compile tested, but looks pretty obvious to me). Something

Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

2007-06-28 Thread Rafael J. Wysocki
On Thursday, 28 June 2007 19:25, Stefan Seyfried wrote: (CC'ing Linus, since disabling consoles during suspend was his idea IIRC) On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote: Hi, On Thursday, 28 June 2007 15:51, Pavel Machek wrote: Hi! What about this?