Re: [RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Borislav Petkov
On Fri, Oct 05, 2012 at 01:49:44PM +0200, Stephane Eranian wrote: > Yeah, unfortunately. I ended up creating a separate table for config1 > and initializing attr.config1 at runtime. That way it works regardless > of the compiler Did the same thing in the persistent events patches recently:

Re: [RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Stephane Eranian
On Fri, Oct 5, 2012 at 1:01 PM, Peter Zijlstra wrote: > On Fri, 2012-10-05 at 12:36 +0200, Stephane Eranian wrote: > >> struct perf_event_attr attr = { .config = 0x1234, .config1 = 0x456 }; > >> Does anyone have a better solution to propose? > > > struct perf_event_attr attr = { >

Re: [RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Peter Zijlstra
On Fri, 2012-10-05 at 12:36 +0200, Stephane Eranian wrote: > struct perf_event_attr attr = { .config = 0x1234, .config1 = 0x456 }; > Does anyone have a better solution to propose? struct perf_event_attr attr = { .config = 0x1234, { .config1 = 0x5678 }, }; sometimes

[RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Stephane Eranian
Hi, I am writing a little test program for the perf_event API which is using hardcoded events. Some of those events (SNBEP uncore events) require a value for config1. I was naively assuming, one could simply do: struct perf_event_attr attr = { .config = 0x1234, .config1 = 0x456 }; However this

[RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Stephane Eranian
Hi, I am writing a little test program for the perf_event API which is using hardcoded events. Some of those events (SNBEP uncore events) require a value for config1. I was naively assuming, one could simply do: struct perf_event_attr attr = { .config = 0x1234, .config1 = 0x456 }; However this

Re: [RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Peter Zijlstra
On Fri, 2012-10-05 at 12:36 +0200, Stephane Eranian wrote: struct perf_event_attr attr = { .config = 0x1234, .config1 = 0x456 }; Does anyone have a better solution to propose? struct perf_event_attr attr = { .config = 0x1234, { .config1 = 0x5678 }, }; sometimes works,

Re: [RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Stephane Eranian
On Fri, Oct 5, 2012 at 1:01 PM, Peter Zijlstra pet...@infradead.org wrote: On Fri, 2012-10-05 at 12:36 +0200, Stephane Eranian wrote: struct perf_event_attr attr = { .config = 0x1234, .config1 = 0x456 }; Does anyone have a better solution to propose? struct perf_event_attr attr = {

Re: [RFC] perf: perf_event_attr anon unions and static initializer issue

2012-10-05 Thread Borislav Petkov
On Fri, Oct 05, 2012 at 01:49:44PM +0200, Stephane Eranian wrote: Yeah, unfortunately. I ended up creating a separate table for config1 and initializing attr.config1 at runtime. That way it works regardless of the compiler Did the same thing in the persistent events patches recently: