Re: [RFC] perf callchain: Compare dsos (as well) for CCKEY_FUNCTION

2017-10-04 Thread Jiri Olsa
On Wed, Oct 04, 2017 at 11:43:08AM +0530, Ravi Bangoria wrote: > Two functions from different binaries can have same start > address. Thus, comparing only start address in match_chain() > leads to inconsistent callchains. Fix this by adding a check > for dsos as well. > > Ex,

Re: [RFC] perf callchain: Compare dsos (as well) for CCKEY_FUNCTION

2017-10-04 Thread Jiri Olsa
On Wed, Oct 04, 2017 at 11:43:08AM +0530, Ravi Bangoria wrote: > Two functions from different binaries can have same start > address. Thus, comparing only start address in match_chain() > leads to inconsistent callchains. Fix this by adding a check > for dsos as well. > > Ex,

[RFC] perf callchain: Compare dsos (as well) for CCKEY_FUNCTION

2017-10-04 Thread Ravi Bangoria
Two functions from different binaries can have same start address. Thus, comparing only start address in match_chain() leads to inconsistent callchains. Fix this by adding a check for dsos as well. Ex, https://www.spinics.net/lists/linux-perf-users/msg04067.html Reported-by: Alexander Pozdneev

[RFC] perf callchain: Compare dsos (as well) for CCKEY_FUNCTION

2017-10-04 Thread Ravi Bangoria
Two functions from different binaries can have same start address. Thus, comparing only start address in match_chain() leads to inconsistent callchains. Fix this by adding a check for dsos as well. Ex, https://www.spinics.net/lists/linux-perf-users/msg04067.html Reported-by: Alexander Pozdneev