Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-25 Thread zhong jiang
On 2016/9/25 8:06, Mike Kravetz wrote: > On 09/23/2016 07:56 PM, zhong jiang wrote: >> On 2016/9/24 1:19, Mike Kravetz wrote: >>> On 09/22/2016 06:53 PM, zhong jiang wrote: At present, we need to call hugetlb_fix_reserve_count when hugetlb_unrserve_pages fails, and PagePrivate will

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-25 Thread zhong jiang
On 2016/9/25 8:06, Mike Kravetz wrote: > On 09/23/2016 07:56 PM, zhong jiang wrote: >> On 2016/9/24 1:19, Mike Kravetz wrote: >>> On 09/22/2016 06:53 PM, zhong jiang wrote: At present, we need to call hugetlb_fix_reserve_count when hugetlb_unrserve_pages fails, and PagePrivate will

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-24 Thread Mike Kravetz
On 09/23/2016 07:56 PM, zhong jiang wrote: > On 2016/9/24 1:19, Mike Kravetz wrote: >> On 09/22/2016 06:53 PM, zhong jiang wrote: >>> At present, we need to call hugetlb_fix_reserve_count when >>> hugetlb_unrserve_pages fails, >>> and PagePrivate will decide hugetlb reserves counts. >>> >>> we

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-24 Thread Mike Kravetz
On 09/23/2016 07:56 PM, zhong jiang wrote: > On 2016/9/24 1:19, Mike Kravetz wrote: >> On 09/22/2016 06:53 PM, zhong jiang wrote: >>> At present, we need to call hugetlb_fix_reserve_count when >>> hugetlb_unrserve_pages fails, >>> and PagePrivate will decide hugetlb reserves counts. >>> >>> we

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-23 Thread zhong jiang
On 2016/9/24 1:19, Mike Kravetz wrote: > On 09/22/2016 06:53 PM, zhong jiang wrote: >> At present, we need to call hugetlb_fix_reserve_count when >> hugetlb_unrserve_pages fails, >> and PagePrivate will decide hugetlb reserves counts. >> >> we obtain the page from page cache. and use page both

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-23 Thread zhong jiang
On 2016/9/24 1:19, Mike Kravetz wrote: > On 09/22/2016 06:53 PM, zhong jiang wrote: >> At present, we need to call hugetlb_fix_reserve_count when >> hugetlb_unrserve_pages fails, >> and PagePrivate will decide hugetlb reserves counts. >> >> we obtain the page from page cache. and use page both

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-23 Thread Mike Kravetz
On 09/22/2016 06:53 PM, zhong jiang wrote: > > At present, we need to call hugetlb_fix_reserve_count when > hugetlb_unrserve_pages fails, > and PagePrivate will decide hugetlb reserves counts. > > we obtain the page from page cache. and use page both lock_page and > mutex_lock. >

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-23 Thread Mike Kravetz
On 09/22/2016 06:53 PM, zhong jiang wrote: > > At present, we need to call hugetlb_fix_reserve_count when > hugetlb_unrserve_pages fails, > and PagePrivate will decide hugetlb reserves counts. > > we obtain the page from page cache. and use page both lock_page and > mutex_lock. >

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-23 Thread Michal Hocko
[CC Naoya] On Fri 23-09-16 09:53:52, zhong jiang wrote: > > At present, we need to call hugetlb_fix_reserve_count when > hugetlb_unrserve_pages fails, > and PagePrivate will decide hugetlb reserves counts. > > we obtain the page from page cache. and use page both lock_page and > mutex_lock. >

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-23 Thread Michal Hocko
[CC Naoya] On Fri 23-09-16 09:53:52, zhong jiang wrote: > > At present, we need to call hugetlb_fix_reserve_count when > hugetlb_unrserve_pages fails, > and PagePrivate will decide hugetlb reserves counts. > > we obtain the page from page cache. and use page both lock_page and > mutex_lock. >

[RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-22 Thread zhong jiang
At present, we need to call hugetlb_fix_reserve_count when hugetlb_unrserve_pages fails, and PagePrivate will decide hugetlb reserves counts. we obtain the page from page cache. and use page both lock_page and mutex_lock. alloc_huge_page add page to page chace always hold lock page, then bail

[RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-22 Thread zhong jiang
At present, we need to call hugetlb_fix_reserve_count when hugetlb_unrserve_pages fails, and PagePrivate will decide hugetlb reserves counts. we obtain the page from page cache. and use page both lock_page and mutex_lock. alloc_huge_page add page to page chace always hold lock page, then bail