Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-13 Thread Yuichi Nakamura
On Thu, 13 Sep 2007 08:58:32 -0400 Stephen Smalley wrote: > On Wed, 2007-09-12 at 17:51 +0900, Yuichi Nakamura wrote: > Thanks, a few comments below. Thanks for comments! > > > > * Description of patch > > This patch improves performance of read/write in SELinux. > > It improves performance by

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-13 Thread Stephen Smalley
On Wed, 2007-09-12 at 17:51 +0900, Yuichi Nakamura wrote: > Hi. > > Stephen Smalley pointed out possibility of race condition > in off-list discussion. > Stephen Smalley said: > > One other observation about the patch: it presently leaves open a > > (small) race window in which the file could

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-13 Thread Stephen Smalley
On Wed, 2007-09-12 at 17:51 +0900, Yuichi Nakamura wrote: Hi. Stephen Smalley pointed out possibility of race condition in off-list discussion. Stephen Smalley said: One other observation about the patch: it presently leaves open a (small) race window in which the file could get

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-13 Thread Yuichi Nakamura
On Thu, 13 Sep 2007 08:58:32 -0400 Stephen Smalley wrote: On Wed, 2007-09-12 at 17:51 +0900, Yuichi Nakamura wrote: snip Thanks, a few comments below. Thanks for comments! * Description of patch This patch improves performance of read/write in SELinux. It improves performance by

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-12 Thread Yuichi Nakamura
Hi. Stephen Smalley pointed out possibility of race condition in off-list discussion. Stephen Smalley said: > One other observation about the patch: it presently leaves open a > (small) race window in which the file could get relabeled or policy gets > reloaded between the time of the normal

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-12 Thread Yuichi Nakamura
Hi. Stephen Smalley pointed out possibility of race condition in off-list discussion. Stephen Smalley said: One other observation about the patch: it presently leaves open a (small) race window in which the file could get relabeled or policy gets reloaded between the time of the normal

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-10 Thread Stephen Smalley
On Mon, 2007-09-10 at 10:31 +0900, Yuichi Nakamura wrote: > Next is updated patch. Thanks. Please include the short description of the patch though when re-submitting. > Signed-off-by: Yuichi Nakamura<[EMAIL PROTECTED]> > --- > fs/open.c |5 + >

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-10 Thread Stephen Smalley
On Mon, 2007-09-10 at 10:31 +0900, Yuichi Nakamura wrote: Next is updated patch. Thanks. Please include the short description of the patch though when re-submitting. Signed-off-by: Yuichi Nakamura[EMAIL PROTECTED] --- fs/open.c |5 + include/linux/security.h

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-09 Thread Yuichi Nakamura
On Thu, 06 Sep 2007 09:47:15 -0400 Stephen Smalley wrote: > > > > @@ -431,8 +432,10 @@ static int avc_latest_notif_update(int s > > ret = -EAGAIN; > > } > > } else { > > - if (seqno > avc_cache.latest_notif) > > + if (seqno >

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-09 Thread Yuichi Nakamura
On Thu, 06 Sep 2007 09:47:15 -0400 Stephen Smalley wrote: snip @@ -431,8 +432,10 @@ static int avc_latest_notif_update(int s ret = -EAGAIN; } } else { - if (seqno avc_cache.latest_notif) + if (seqno avc_cache.latest_notif)

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-06 Thread Stephen Smalley
On Thu, 2007-09-06 at 16:27 +0900, Yuichi Nakamura wrote: > Hello. > > As I posted before in selinux list, > I found big overhead of SELinux in read/write on some CPUs, > and trying tuning. > There were discussion in previous threads. > Part 1: > http://marc.info/?t=11884534341=1=2 > Part 2:

[RFC]selinux: Improving SELinux read/write performance

2007-09-06 Thread Yuichi Nakamura
Hello. As I posted before in selinux list, I found big overhead of SELinux in read/write on some CPUs, and trying tuning. There were discussion in previous threads. Part 1: http://marc.info/?t=11884534341=1=2 Part 2: http://marc.info/?t=11888074984=1=2 I would like to RFC again about

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-06 Thread Stephen Smalley
On Thu, 2007-09-06 at 16:27 +0900, Yuichi Nakamura wrote: Hello. As I posted before in selinux list, I found big overhead of SELinux in read/write on some CPUs, and trying tuning. There were discussion in previous threads. Part 1: http://marc.info/?t=11884534341r=1w=2 Part 2: