Re: [RFC / BUG] mtd: provide proper 32/64-bit compat_ioctl() support for BLKPG

2015-08-31 Thread Brian Norris
On Fri, Aug 28, 2015 at 07:12:36PM -0700, Brian Norris wrote: > The same bug applies to block/ioctl.c Actually I'll correct myself: it looks like block/ already has OK compat_ioctl support for this. Block devices do a copy to/from user space to marshal a new struct. Personally, I find my approach

Re: [RFC / BUG] mtd: provide proper 32/64-bit compat_ioctl() support for BLKPG

2015-08-31 Thread Brian Norris
On Fri, Aug 28, 2015 at 07:12:36PM -0700, Brian Norris wrote: > The same bug applies to block/ioctl.c Actually I'll correct myself: it looks like block/ already has OK compat_ioctl support for this. Block devices do a copy to/from user space to marshal a new struct. Personally, I find my approach

[RFC / BUG] mtd: provide proper 32/64-bit compat_ioctl() support for BLKPG

2015-08-28 Thread Brian Norris
After a bit of poking around wondering why my 32-bit user-space can't seem to send a proper ioctl(BLKPG) to an MTD on my 64-bit kernel (ARM64), I noticed that struct blkpg_ioctl_arg is actually pretty unsuitable for use in the ioctl() ABI, due to its use of raw pointers, and its lack of

[RFC / BUG] mtd: provide proper 32/64-bit compat_ioctl() support for BLKPG

2015-08-28 Thread Brian Norris
After a bit of poking around wondering why my 32-bit user-space can't seem to send a proper ioctl(BLKPG) to an MTD on my 64-bit kernel (ARM64), I noticed that struct blkpg_ioctl_arg is actually pretty unsuitable for use in the ioctl() ABI, due to its use of raw pointers, and its lack of