Re: [RFC 1/3] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe

2012-10-03 Thread Fabio Estevam
On Wed, Oct 3, 2012 at 2:36 PM, Mark Brown wrote: > I still don't understand what on earth this is doing, as far as I can > tell there's only one domain in the device so you're not distrubting > anything between domains and there's as many interrupts in this domain > as there are in the domain al

Re: [RFC 1/3] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe

2012-10-03 Thread Mark Brown
On Wed, Oct 03, 2012 at 02:06:57PM -0300, Fabio Estevam wrote: > + /* Allocate a virtual IRQ domain to distribute to the regmap domains */ > + da9052->virq = irq_domain_add_linear(NULL, ARRAY_SIZE(da9052_irqs), > + &da9052_domain_ops, da9052); >

[RFC 1/3] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe

2012-10-03 Thread Fabio Estevam
From: Fabio Estevam On a mx53qsb dt-kernel the da9052-core driver fails to probe as follows: da9052 1-0048: DA9052 ADC IRQ failed ret=-22 The reason for the error was due to passing only the offset as the interrupt number in request_threaded_irq(). The recommended approach though is to use reg