Re: [RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-15 Thread Paul E. McKenney
On Wed, Jan 15, 2014 at 08:48:44AM +0100, Peter Zijlstra wrote: > On Wed, Jan 15, 2014 at 08:44:20AM +0100, Peter Zijlstra wrote: > > On Tue, Jan 14, 2014 at 04:33:08PM -0800, Jason Low wrote: > > > The mutex_can_spin_on_owner() function should also return false if the > > > task needs to be

Re: [RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-15 Thread Paul E. McKenney
On Wed, Jan 15, 2014 at 08:48:44AM +0100, Peter Zijlstra wrote: On Wed, Jan 15, 2014 at 08:44:20AM +0100, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 04:33:08PM -0800, Jason Low wrote: The mutex_can_spin_on_owner() function should also return false if the task needs to be rescheduled.

Re: [RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-14 Thread Peter Zijlstra
On Wed, Jan 15, 2014 at 08:44:20AM +0100, Peter Zijlstra wrote: > On Tue, Jan 14, 2014 at 04:33:08PM -0800, Jason Low wrote: > > The mutex_can_spin_on_owner() function should also return false if the > > task needs to be rescheduled. > > > > While I was staring at mutex_can_spin_on_owner();

Re: [RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-14 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 04:33:08PM -0800, Jason Low wrote: > The mutex_can_spin_on_owner() function should also return false if the > task needs to be rescheduled. > While I was staring at mutex_can_spin_on_owner(); don't we need this? kernel/locking/mutex.c | 4 +++- 1 file changed, 3

[RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-14 Thread Jason Low
The mutex_can_spin_on_owner() function should also return false if the task needs to be rescheduled. Signed-off-by: Jason Low --- kernel/locking/mutex.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c index

[RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-14 Thread Jason Low
The mutex_can_spin_on_owner() function should also return false if the task needs to be rescheduled. Signed-off-by: Jason Low jason.l...@hp.com --- kernel/locking/mutex.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c

Re: [RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-14 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 04:33:08PM -0800, Jason Low wrote: The mutex_can_spin_on_owner() function should also return false if the task needs to be rescheduled. While I was staring at mutex_can_spin_on_owner(); don't we need this? kernel/locking/mutex.c | 4 +++- 1 file changed, 3

Re: [RFC 1/3] mutex: In mutex_can_spin_on_owner(), return false if task need_resched()

2014-01-14 Thread Peter Zijlstra
On Wed, Jan 15, 2014 at 08:44:20AM +0100, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 04:33:08PM -0800, Jason Low wrote: The mutex_can_spin_on_owner() function should also return false if the task needs to be rescheduled. While I was staring at mutex_can_spin_on_owner(); don't we need