Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-05-09 Thread Ravi Bangoria
Hi Arnaldo, Thanks for the review. Please find my comments below. On Thursday 28 April 2016 03:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Apr 27, 2016 at 06:02:21PM +0530, Ravi Bangoria escreveu: Hi Arnaldo, I've worked on your patch. I'm sending this patch(diff) to check if this is the

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-05-09 Thread Ravi Bangoria
Hi Arnaldo, Thanks for the review. Please find my comments below. On Thursday 28 April 2016 03:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Apr 27, 2016 at 06:02:21PM +0530, Ravi Bangoria escreveu: Hi Arnaldo, I've worked on your patch. I'm sending this patch(diff) to check if this is the

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-04-27 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 27, 2016 at 06:02:21PM +0530, Ravi Bangoria escreveu: > Hi Arnaldo, > > I've worked on your patch. I'm sending this patch(diff) to check if this > is the same idea you want to progress with. I cleanup your patch, > removed arch specific compile time directives and changed code to >

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-04-27 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 27, 2016 at 06:02:21PM +0530, Ravi Bangoria escreveu: > Hi Arnaldo, > > I've worked on your patch. I'm sending this patch(diff) to check if this > is the same idea you want to progress with. I cleanup your patch, > removed arch specific compile time directives and changed code to >

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-04-27 Thread Ravi Bangoria
Hi Arnaldo, I've worked on your patch. I'm sending this patch(diff) to check if this is the same idea you want to progress with. I cleanup your patch, removed arch specific compile time directives and changed code to enable cross arch reporting. I tested record on powerpc and report on x86 and

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-04-27 Thread Ravi Bangoria
Hi Arnaldo, I've worked on your patch. I'm sending this patch(diff) to check if this is the same idea you want to progress with. I cleanup your patch, removed arch specific compile time directives and changed code to enable cross arch reporting. I tested record on powerpc and report on x86 and

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-28 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 28, 2016 at 04:28:45PM +0530, Ravi Bangoria escreveu: > Thanks Arnaldo for putting the effort. > > I've tested this patch on powerpc and it looks fine to me. Please find my > below comments. > > On Friday 25 March 2016 02:45 AM, Arnaldo Carvalho de Melo wrote: > >Em Tue, Mar 22, 2016

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-28 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 28, 2016 at 04:28:45PM +0530, Ravi Bangoria escreveu: > Thanks Arnaldo for putting the effort. > > I've tested this patch on powerpc and it looks fine to me. Please find my > below comments. > > On Friday 25 March 2016 02:45 AM, Arnaldo Carvalho de Melo wrote: > >Em Tue, Mar 22, 2016

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-28 Thread Ravi Bangoria
Thanks Arnaldo for putting the effort. I've tested this patch on powerpc and it looks fine to me. Please find my below comments. On Friday 25 March 2016 02:45 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 22, 2016 at 11:19:21PM -0300, Arnaldo Carvalho de Melo escreveu: Em Tue, Mar 22,

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-28 Thread Ravi Bangoria
Thanks Arnaldo for putting the effort. I've tested this patch on powerpc and it looks fine to me. Please find my below comments. On Friday 25 March 2016 02:45 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 22, 2016 at 11:19:21PM -0300, Arnaldo Carvalho de Melo escreveu: Em Tue, Mar 22,

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-24 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 22, 2016 at 11:19:21PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Mar 22, 2016 at 04:12:11PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Feb 24, 2016 at 02:37:42PM +0530, Ravi Bangoria escreveu: > > > 'perf kvm record' is not available on powerpc because 'perf'

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-24 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 22, 2016 at 11:19:21PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Mar 22, 2016 at 04:12:11PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Feb 24, 2016 at 02:37:42PM +0530, Ravi Bangoria escreveu: > > > 'perf kvm record' is not available on powerpc because 'perf'

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-22 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 22, 2016 at 04:12:11PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Feb 24, 2016 at 02:37:42PM +0530, Ravi Bangoria escreveu: > > 'perf kvm record' is not available on powerpc because 'perf' relies on > > the 'cycles' event (a PMU event) to profile the guest. However, for > >

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-22 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 22, 2016 at 04:12:11PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Feb 24, 2016 at 02:37:42PM +0530, Ravi Bangoria escreveu: > > 'perf kvm record' is not available on powerpc because 'perf' relies on > > the 'cycles' event (a PMU event) to profile the guest. However, for > >

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-22 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2016 at 02:37:42PM +0530, Ravi Bangoria escreveu: > 'perf kvm record' is not available on powerpc because 'perf' relies on > the 'cycles' event (a PMU event) to profile the guest. However, for > powerpc, this can't be used from the host because the PMUs are controlled > by the

Re: [RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-03-22 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2016 at 02:37:42PM +0530, Ravi Bangoria escreveu: > 'perf kvm record' is not available on powerpc because 'perf' relies on > the 'cycles' event (a PMU event) to profile the guest. However, for > powerpc, this can't be used from the host because the PMUs are controlled > by the

[RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-02-24 Thread Ravi Bangoria
'perf kvm record' is not available on powerpc because 'perf' relies on the 'cycles' event (a PMU event) to profile the guest. However, for powerpc, this can't be used from the host because the PMUs are controlled by the guest rather than the host. There exists a tracepoint 'kvm_hv:kvm_guest_exit'

[RFC 1/4] perf kvm: Enable 'record' on powerpc

2016-02-24 Thread Ravi Bangoria
'perf kvm record' is not available on powerpc because 'perf' relies on the 'cycles' event (a PMU event) to profile the guest. However, for powerpc, this can't be used from the host because the PMUs are controlled by the guest rather than the host. There exists a tracepoint 'kvm_hv:kvm_guest_exit'