Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-03 Thread Michal Hocko
On Thu 02-08-18 22:17:49, Jeremy Linton wrote: > Hi, > > On 08/02/2018 02:31 AM, Michal Hocko wrote: > > On Wed 01-08-18 15:04:18, Jeremy Linton wrote: > > > Its possible to crash __alloc_pages_nodemask by passing it > > > bogus node ids. This is caused by NODE_DATA() returning null > > >

Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-03 Thread Michal Hocko
On Thu 02-08-18 22:17:49, Jeremy Linton wrote: > Hi, > > On 08/02/2018 02:31 AM, Michal Hocko wrote: > > On Wed 01-08-18 15:04:18, Jeremy Linton wrote: > > > Its possible to crash __alloc_pages_nodemask by passing it > > > bogus node ids. This is caused by NODE_DATA() returning null > > >

Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 02:31 AM, Michal Hocko wrote: On Wed 01-08-18 15:04:18, Jeremy Linton wrote: Its possible to crash __alloc_pages_nodemask by passing it bogus node ids. This is caused by NODE_DATA() returning null (hopefully) when the requested node is offline. We can harded against the basic

Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 02:31 AM, Michal Hocko wrote: On Wed 01-08-18 15:04:18, Jeremy Linton wrote: Its possible to crash __alloc_pages_nodemask by passing it bogus node ids. This is caused by NODE_DATA() returning null (hopefully) when the requested node is offline. We can harded against the basic

Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-02 Thread Michal Hocko
On Wed 01-08-18 15:04:18, Jeremy Linton wrote: > Its possible to crash __alloc_pages_nodemask by passing it > bogus node ids. This is caused by NODE_DATA() returning null > (hopefully) when the requested node is offline. We can > harded against the basic case of a mostly valid node, that > isn't

Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-02 Thread Michal Hocko
On Wed 01-08-18 15:04:18, Jeremy Linton wrote: > Its possible to crash __alloc_pages_nodemask by passing it > bogus node ids. This is caused by NODE_DATA() returning null > (hopefully) when the requested node is offline. We can > harded against the basic case of a mostly valid node, that > isn't

[RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-01 Thread Jeremy Linton
Its possible to crash __alloc_pages_nodemask by passing it bogus node ids. This is caused by NODE_DATA() returning null (hopefully) when the requested node is offline. We can harded against the basic case of a mostly valid node, that isn't online by checking for null and failing

[RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-01 Thread Jeremy Linton
Its possible to crash __alloc_pages_nodemask by passing it bogus node ids. This is caused by NODE_DATA() returning null (hopefully) when the requested node is offline. We can harded against the basic case of a mostly valid node, that isn't online by checking for null and failing