Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, Feb 26, 2016 at 5:00 PM, Horng-Shyang Liao wrote: > > On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > > Hi Dan, > > > > > > Thanks for your comment. > > > This solution looks good to me. > > > I will change it as your suggestion. > > > > > > But, I have a

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, Feb 26, 2016 at 5:00 PM, Horng-Shyang Liao wrote: > > On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > > Hi Dan, > > > > > > Thanks for your comment. > > > This solution looks good to me. > > > I will change it as your suggestion. > > > > > > But, I have a question about 'mask

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > Hi Dan, > > > > Thanks for your comment. > > This solution looks good to me. > > I will change it as your suggestion. > > > > But, I have a question about 'mask out the provided *device virtual* > > address'. > > Are lower 16-bits (or

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > Hi Dan, > > > > Thanks for your comment. > > This solution looks good to me. > > I will change it as your suggestion. > > > > But, I have a question about 'mask out the provided *device virtual* > > address'. > > Are lower 16-bits (or

Re: FW: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > Hi Dan, > > > > Thanks for your comment. > > This solution looks good to me. > > I will change it as your suggestion. > > > > But, I have a question about 'mask out the provided *device virtual* > > address'. > > Are lower 16-bits (or

Re: FW: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > Hi Dan, > > > > Thanks for your comment. > > This solution looks good to me. > > I will change it as your suggestion. > > > > But, I have a question about 'mask out the provided *device virtual* > > address'. > > Are lower 16-bits (or

Re: FW: [RFC 3/3] CMDQ: Mediatek CMDQ driver

> Hi Dan, > > Thanks for your comment. > This solution looks good to me. > I will change it as your suggestion. > > But, I have a question about 'mask out the provided *device virtual* > address'. > Are lower 16-bits (or 24-bits for JUMP op) of device virtual address the > same as device physical

Re: FW: [RFC 3/3] CMDQ: Mediatek CMDQ driver

霆); Daoyuan Huang (黃道原); Damon Chu (朱峻賢); Josh-YC Liu > (劉育誠); Glory Hung (洪智瑋); Yong Wu (吴勇) > Subject: Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver > > On Tue, Feb 2, 2016 at 2:48 PM, Horng-Shyang Liao > wrote: > > On Mon, 2016-02-01 at 18:22 +0800, Daniel Kurtz wrote: >

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Tue, Feb 2, 2016 at 2:48 PM, Horng-Shyang Liao wrote: > On Mon, 2016-02-01 at 18:22 +0800, Daniel Kurtz wrote: >> On Mon, Feb 1, 2016 at 2:20 PM, Horng-Shyang Liao >> wrote: >> > On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: >> >> On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao

Re: FW: [RFC 3/3] CMDQ: Mediatek CMDQ driver

霆); Daoyuan Huang (黃道原); Damon Chu (朱峻賢); Josh-YC Liu > (劉育誠); Glory Hung (洪智瑋); Yong Wu (吴勇) > Subject: Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver > > On Tue, Feb 2, 2016 at 2:48 PM, Horng-Shyang Liao <hs.l...@mediatek.com> > wrote: > > On Mon, 2016-02-01 at 18:22 +0800

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Tue, Feb 2, 2016 at 2:48 PM, Horng-Shyang Liao wrote: > On Mon, 2016-02-01 at 18:22 +0800, Daniel Kurtz wrote: >> On Mon, Feb 1, 2016 at 2:20 PM, Horng-Shyang Liao >> wrote: >> > On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: >> >> On Mon,

Re: FW: [RFC 3/3] CMDQ: Mediatek CMDQ driver

> Hi Dan, > > Thanks for your comment. > This solution looks good to me. > I will change it as your suggestion. > > But, I have a question about 'mask out the provided *device virtual* > address'. > Are lower 16-bits (or 24-bits for JUMP op) of device virtual address the > same as device physical

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-02-01 at 18:22 +0800, Daniel Kurtz wrote: > On Mon, Feb 1, 2016 at 2:20 PM, Horng-Shyang Liao > wrote: > > On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: > >> On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao > >> wrote: > >> > > >> > On Fri, 2016-01-29 at 21:15 +0800,

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, Feb 1, 2016 at 2:20 PM, Horng-Shyang Liao wrote: > On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: >> On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao >> wrote: >> > >> > On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: >> > > On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, Feb 1, 2016 at 2:20 PM, Horng-Shyang Liao wrote: > On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: >> On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao >> wrote: >> > >> > On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: >> > >

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-02-01 at 18:22 +0800, Daniel Kurtz wrote: > On Mon, Feb 1, 2016 at 2:20 PM, Horng-Shyang Liao > wrote: > > On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: > >> On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao > >> wrote: > >> >

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: > On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao > wrote: > > > > On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: > > > On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao > > > wrote: > > > > On Fri, 2016-01-29 at 16:42 +0800,

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao wrote: > > On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: > > On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao > > wrote: > > > On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: > > >> On Fri, Jan 29, 2016 at 3:39 PM,

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: > On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao > wrote: > > On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: > >> On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao > >> wrote: > >> > Hi Dan, > >> > > >> > Many thanks for your

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-02-01 at 12:15 +0800, Daniel Kurtz wrote: > On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao > wrote: > > > > On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: > > > On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao > > > wrote:

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: > On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao > wrote: > > On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: > >> On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao > >> wrote: > >> >

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Mon, Feb 1, 2016 at 10:04 AM, Horng-Shyang Liao wrote: > > On Fri, 2016-01-29 at 21:15 +0800, Daniel Kurtz wrote: > > On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao > > wrote: > > > On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: > > >>

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao wrote: > On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: >> On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao >> wrote: >> > Hi Dan, >> > >> > Many thanks for your comments and time. >> > I reply my plan inline. >> > >> > >> > On Thu,

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: > On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao > wrote: > > Hi Dan, > > > > Many thanks for your comments and time. > > I reply my plan inline. > > > > > > On Thu, 2016-01-28 at 12:49 +0800, Daniel Kurtz wrote: > >> Hi HS, > >> > >>

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao wrote: > Hi Dan, > > Many thanks for your comments and time. > I reply my plan inline. > > > On Thu, 2016-01-28 at 12:49 +0800, Daniel Kurtz wrote: >> Hi HS, >> >> Sorry for the delay. It is hard to find time to review a >3700 line >> driver :-o

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: > On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao > wrote: > > Hi Dan, > > > > Many thanks for your comments and time. > > I reply my plan inline. > > > > > > On Thu, 2016-01-28 at 12:49 +0800, Daniel Kurtz wrote: >

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, Jan 29, 2016 at 8:24 PM, Horng-Shyang Liao wrote: > On Fri, 2016-01-29 at 16:42 +0800, Daniel Kurtz wrote: >> On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao >> wrote: >> > Hi Dan, >> > >> > Many thanks for your comments and time. >> > I

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Fri, Jan 29, 2016 at 3:39 PM, Horng-Shyang Liao wrote: > Hi Dan, > > Many thanks for your comments and time. > I reply my plan inline. > > > On Thu, 2016-01-28 at 12:49 +0800, Daniel Kurtz wrote: >> Hi HS, >> >> Sorry for the delay. It is hard to find time to review a

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

Hi Dan, Many thanks for your comments and time. I reply my plan inline. On Thu, 2016-01-28 at 12:49 +0800, Daniel Kurtz wrote: > Hi HS, > > Sorry for the delay. It is hard to find time to review a >3700 line > driver :-o in detail > > Some review comments inline, although I still do not

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

Hi Dan, Many thanks for your comments and time. I reply my plan inline. On Thu, 2016-01-28 at 12:49 +0800, Daniel Kurtz wrote: > Hi HS, > > Sorry for the delay. It is hard to find time to review a >3700 line > driver :-o in detail > > Some review comments inline, although I still do not

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

Hi HS, Sorry for the delay. It is hard to find time to review a >3700 line driver :-o in detail Some review comments inline, although I still do not completely understand how all that this driver does and how it works. I'll try to find time to go through this driver in detail again next

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

Hi HS, Sorry for the delay. It is hard to find time to review a >3700 line driver :-o in detail Some review comments inline, although I still do not completely understand how all that this driver does and how it works. I'll try to find time to go through this driver in detail again next