Re: [RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource

2013-05-12 Thread Shawn Guo
On Sat, May 11, 2013 at 02:33:56PM +0900, Jingoo Han wrote: > On Friday, May 10, 2013 5:17 PM, Wolfram Sang wrote: > > > > devm_ioremap_resource does sanity checks on the given resource. No need to > > duplicate this in the driver. > > > > Signed-off-by: Wolfram Sang > > CC'ed Tomi Valkeinen,

Re: [RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource

2013-05-12 Thread Shawn Guo
On Sat, May 11, 2013 at 02:33:56PM +0900, Jingoo Han wrote: On Friday, May 10, 2013 5:17 PM, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de CC'ed Tomi

Re: [RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource

2013-05-10 Thread Jingoo Han
On Friday, May 10, 2013 5:17 PM, Wolfram Sang wrote: > > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang CC'ed Tomi Valkeinen, Shawn Guo, Fabio Estevam It looks good. Reviewed-by: Jingoo Han Best

[RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/video/mxsfb.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index

[RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/video/mxsfb.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/mxsfb.c

Re: [RFC 32/42] drivers/video: don't check resource with devm_ioremap_resource

2013-05-10 Thread Jingoo Han
On Friday, May 10, 2013 5:17 PM, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de CC'ed Tomi Valkeinen, Shawn Guo, Fabio Estevam It looks good. Reviewed-by: Jingoo