Re: [patch] Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Ingo Molnar
* Mike Galbraith wrote: > > Willing to write a changelog with the pointer to the actual > > oops that happens due to this issue? > > I don't have a link, so reproduced/captured it. With > systemd-sysvinit (bleh) installed, it's trivial to reproduce: > > Add echo 0 >

[patch] Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Mike Galbraith
On Sun, 2012-12-02 at 11:36 -0800, Linus Torvalds wrote: > On Sun, Dec 2, 2012 at 11:27 AM, Ingo Molnar wrote: > > > > * Mike Galbraith wrote: > > > >> On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: > >> > >> > Should we use some other file for that - or no file at all and > >> > just

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Linus Torvalds
On Sun, Dec 2, 2012 at 11:27 AM, Ingo Molnar wrote: > > * Mike Galbraith wrote: > >> On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: >> >> > Should we use some other file for that - or no file at all and >> > just emit a bootup printk for kernel hackers with a short >> > attention span? >>

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Ingo Molnar
* Mike Galbraith wrote: > On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: > > > Should we use some other file for that - or no file at all and > > just emit a bootup printk for kernel hackers with a short > > attention span? > > Or, whack the file and don't bother with a printk

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Mike Galbraith
On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: > Should we use some other file for that - or no file at all and > just emit a bootup printk for kernel hackers with a short > attention span? Or, whack the file and don't bother with a printk either. If it's in your config, and your

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Mike Galbraith
On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: Should we use some other file for that - or no file at all and just emit a bootup printk for kernel hackers with a short attention span? Or, whack the file and don't bother with a printk either. If it's in your config, and your command

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Ingo Molnar
* Mike Galbraith efa...@gmx.de wrote: On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: Should we use some other file for that - or no file at all and just emit a bootup printk for kernel hackers with a short attention span? Or, whack the file and don't bother with a printk

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Linus Torvalds
On Sun, Dec 2, 2012 at 11:27 AM, Ingo Molnar mi...@kernel.org wrote: * Mike Galbraith efa...@gmx.de wrote: On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: Should we use some other file for that - or no file at all and just emit a bootup printk for kernel hackers with a short

[patch] Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Mike Galbraith
On Sun, 2012-12-02 at 11:36 -0800, Linus Torvalds wrote: On Sun, Dec 2, 2012 at 11:27 AM, Ingo Molnar mi...@kernel.org wrote: * Mike Galbraith efa...@gmx.de wrote: On Sat, 2012-12-01 at 22:44 +0100, Ingo Molnar wrote: Should we use some other file for that - or no file at all and

Re: [patch] Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-02 Thread Ingo Molnar
* Mike Galbraith efa...@gmx.de wrote: Willing to write a changelog with the pointer to the actual oops that happens due to this issue? I don't have a link, so reproduced/captured it. With systemd-sysvinit (bleh) installed, it's trivial to reproduce: Add echo 0

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Mike Galbraith
On Sat, 2012-12-01 at 14:03 -0800, Linus Torvalds wrote: > On Sat, Dec 1, 2012 at 1:44 PM, Ingo Molnar wrote: > > > > You are not missing anything. That flag is my fault not Mike's: > > I booted the initial version of that patch but was unsure > > whether autogroups was enabled - it's a pretty

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Linus Torvalds
On Sat, Dec 1, 2012 at 1:44 PM, Ingo Molnar wrote: > > You are not missing anything. That flag is my fault not Mike's: > I booted the initial version of that patch but was unsure > whether autogroups was enabled - it's a pretty transparent > feature. So I figured that having that flag (but

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Ingo Molnar
* Ingo Molnar wrote: > You are not missing anything. That flag is my fault not > Mike's: I booted the initial version of that patch but was > unsure whether autogroups was enabled - it's a pretty > transparent feature. So I figured that having that flag (but > readonly) would give us this

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Ingo Molnar
* Linus Torvalds wrote: > On Sat, Dec 1, 2012 at 3:16 AM, Ingo Molnar wrote: > > > > Please [RFC] pull the latest sched-urgent-for-linus git tree > > from: > > No. That patch is braindead. I wouldn't pull it even if it > wasn't this late. > > Why the hell leave a read-only

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Linus Torvalds
On Sat, Dec 1, 2012 at 3:16 AM, Ingo Molnar wrote: > > Please [RFC] pull the latest sched-urgent-for-linus git tree > from: No. That patch is braindead. I wouldn't pull it even if it wasn't this late. Why the hell leave a read-only 'sched_autogroup_enabled' proc file? What the f*ck is the

[RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Ingo Molnar
Linus, Please [RFC] pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus HEAD: 5258f386ea4e8454bc801fb443e8a4217da1947c sched/autogroup: Fix crash on reboot when autogroup is disabled Larger and scarier

[RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Ingo Molnar
Linus, Please [RFC] pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus HEAD: 5258f386ea4e8454bc801fb443e8a4217da1947c sched/autogroup: Fix crash on reboot when autogroup is disabled Larger and scarier

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Linus Torvalds
On Sat, Dec 1, 2012 at 3:16 AM, Ingo Molnar mi...@kernel.org wrote: Please [RFC] pull the latest sched-urgent-for-linus git tree from: No. That patch is braindead. I wouldn't pull it even if it wasn't this late. Why the hell leave a read-only 'sched_autogroup_enabled' proc file? What the f*ck

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Ingo Molnar
* Linus Torvalds torva...@linux-foundation.org wrote: On Sat, Dec 1, 2012 at 3:16 AM, Ingo Molnar mi...@kernel.org wrote: Please [RFC] pull the latest sched-urgent-for-linus git tree from: No. That patch is braindead. I wouldn't pull it even if it wasn't this late. Why the hell

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: You are not missing anything. That flag is my fault not Mike's: I booted the initial version of that patch but was unsure whether autogroups was enabled - it's a pretty transparent feature. So I figured that having that flag (but readonly) would

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Linus Torvalds
On Sat, Dec 1, 2012 at 1:44 PM, Ingo Molnar mi...@kernel.org wrote: You are not missing anything. That flag is my fault not Mike's: I booted the initial version of that patch but was unsure whether autogroups was enabled - it's a pretty transparent feature. So I figured that having that flag

Re: [RFC GIT PULL] scheduler fix for autogroups

2012-12-01 Thread Mike Galbraith
On Sat, 2012-12-01 at 14:03 -0800, Linus Torvalds wrote: On Sat, Dec 1, 2012 at 1:44 PM, Ingo Molnar mi...@kernel.org wrote: You are not missing anything. That flag is my fault not Mike's: I booted the initial version of that patch but was unsure whether autogroups was enabled - it's a