Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-07-17 Thread jeffy
Hi Oliver, Thanks for your reply. On 07/17/2017 11:26 PM, Oliver Neukum wrote: Am Mittwoch, den 12.07.2017, 10:27 +0800 schrieb jeffy: Hi Oliver, Thanx for your comments, and sorry for reply late. If you do that you have to change submit_tx_urb() to be called under a spinlock. sorry, why

Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-07-17 Thread jeffy
Hi Oliver, Thanks for your reply. On 07/17/2017 11:26 PM, Oliver Neukum wrote: Am Mittwoch, den 12.07.2017, 10:27 +0800 schrieb jeffy: Hi Oliver, Thanx for your comments, and sorry for reply late. If you do that you have to change submit_tx_urb() to be called under a spinlock. sorry, why

Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-07-17 Thread Oliver Neukum
Am Mittwoch, den 12.07.2017, 10:27 +0800 schrieb jeffy: > Hi Oliver, > > Thanx for your comments, and sorry for reply late. > > > > If you do that you have to change submit_tx_urb() to be called under a > > spinlock. > > sorry, why we need that? since submit_tx_urb is basically >

Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-07-17 Thread Oliver Neukum
Am Mittwoch, den 12.07.2017, 10:27 +0800 schrieb jeffy: > Hi Oliver, > > Thanx for your comments, and sorry for reply late. > > > > If you do that you have to change submit_tx_urb() to be called under a > > spinlock. > > sorry, why we need that? since submit_tx_urb is basically >

Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-07-11 Thread jeffy
Hi Oliver, Thanx for your comments, and sorry for reply late. On 07/04/2017 07:38 PM, Oliver Neukum wrote: Am Freitag, den 23.06.2017, 11:46 +0800 schrieb jeffy: --- drivers/bluetooth/btusb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c

Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-07-11 Thread jeffy
Hi Oliver, Thanx for your comments, and sorry for reply late. On 07/04/2017 07:38 PM, Oliver Neukum wrote: Am Freitag, den 23.06.2017, 11:46 +0800 schrieb jeffy: --- drivers/bluetooth/btusb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c

Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-06-22 Thread Marcel Holtmann
Hi Jeffy, > Currently in play_deferred, we are calling usb_submit_urb directly to > submit deferred tx urb after unanchor it. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak: > unreferenced object 0xffc0ce0fa400 (size 256): > ... >

Re: [RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-06-22 Thread Marcel Holtmann
Hi Jeffy, > Currently in play_deferred, we are calling usb_submit_urb directly to > submit deferred tx urb after unanchor it. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak: > unreferenced object 0xffc0ce0fa400 (size 256): > ... >

[RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-06-22 Thread Jeffy Chen
Currently in play_deferred, we are calling usb_submit_urb directly to submit deferred tx urb after unanchor it. So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb and cause memory leak: unreferenced object 0xffc0ce0fa400 (size 256): ... backtrace: []

[RFC PATCH] Bluetooth: btusb: Fix memory leak in play_deferred

2017-06-22 Thread Jeffy Chen
Currently in play_deferred, we are calling usb_submit_urb directly to submit deferred tx urb after unanchor it. So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb and cause memory leak: unreferenced object 0xffc0ce0fa400 (size 256): ... backtrace: []