Re: [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown

2020-09-10 Thread Tiezhu Yang
On 09/11/2020 10:35 AM, Oliver O'Halloran wrote: On Fri, Sep 11, 2020 at 11:55 AM Tiezhu Yang wrote: On 09/11/2020 04:21 AM, Bjorn Helgaas wrote: [+cc Huacai] On Thu, Sep 10, 2020 at 02:41:39PM -0500, Bjorn Helgaas wrote: On Sat, Sep 05, 2020 at 04:33:26PM +0800, Tiezhu Yang wrote: After

Re: [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown

2020-09-10 Thread Oliver O'Halloran
On Fri, Sep 11, 2020 at 11:55 AM Tiezhu Yang wrote: > > On 09/11/2020 04:21 AM, Bjorn Helgaas wrote: > > [+cc Huacai] > > > > On Thu, Sep 10, 2020 at 02:41:39PM -0500, Bjorn Helgaas wrote: > >> On Sat, Sep 05, 2020 at 04:33:26PM +0800, Tiezhu Yang wrote: > >>> After commit 745be2e700cd ("PCIe:

Re: [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown

2020-09-10 Thread Tiezhu Yang
On 09/11/2020 04:21 AM, Bjorn Helgaas wrote: [+cc Huacai] On Thu, Sep 10, 2020 at 02:41:39PM -0500, Bjorn Helgaas wrote: On Sat, Sep 05, 2020 at 04:33:26PM +0800, Tiezhu Yang wrote: After commit 745be2e700cd ("PCIe: portdrv: call pci_disable_device during remove") and commit cc27b735ad3a

Re: [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown

2020-09-10 Thread Bjorn Helgaas
[+cc Huacai] On Thu, Sep 10, 2020 at 02:41:39PM -0500, Bjorn Helgaas wrote: > On Sat, Sep 05, 2020 at 04:33:26PM +0800, Tiezhu Yang wrote: > > After commit 745be2e700cd ("PCIe: portdrv: call pci_disable_device > > during remove") and commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe > > services

Re: [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown

2020-09-10 Thread Bjorn Helgaas
On Sat, Sep 05, 2020 at 04:33:26PM +0800, Tiezhu Yang wrote: > After commit 745be2e700cd ("PCIe: portdrv: call pci_disable_device > during remove") and commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe > services during shutdown"), it also calls pci_disable_device() during > shutdown, this seems

[RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown

2020-09-05 Thread Tiezhu Yang
After commit 745be2e700cd ("PCIe: portdrv: call pci_disable_device during remove") and commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown"), it also calls pci_disable_device() during shutdown, this seems unnecessary, so just remove it. Signed-off-by: Tiezhu Yang ---