Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
2013/11/22 Phillip Lougher : > On 22/11/13 21:50, Geyslan Gregório Bem wrote: >> >> Coverity caught double free possibility (CID 1130962). >> >> I can patch this, but I have to know if is correct to free comp_opts >> in the function squashfs_decompressor_create() or it had to be done in >> the

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Phillip Lougher
On 22/11/13 21:50, Geyslan Gregório Bem wrote: Coverity caught double free possibility (CID 1130962). I can patch this, but I have to know if is correct to free comp_opts in the function squashfs_decompressor_create() or it had to be done in the caller. My bet is the caller. 128void

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
2013/11/22 Richard Weinberger : > On Fri, Nov 22, 2013 at 10:50 PM, Geyslan Gregório Bem > wrote: >> Coverity caught double free possibility (CID 1130962). > > Just wondering, where can one find/verify such CIDs? > > -- > Thanks, > //richard Anyone can sign in (https://scan.coverity.com/) and

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Richard Weinberger
On Fri, Nov 22, 2013 at 10:50 PM, Geyslan Gregório Bem wrote: > Coverity caught double free possibility (CID 1130962). Just wondering, where can one find/verify such CIDs? -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
Coverity caught double free possibility (CID 1130962). I can patch this, but I have to know if is correct to free comp_opts in the function squashfs_decompressor_create() or it had to be done in the caller. My bet is the caller. 128void *squashfs_decompressor_setup(struct super_block *sb,

[RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
Coverity caught double free possibility (CID 1130962). I can patch this, but I have to know if is correct to free comp_opts in the function squashfs_decompressor_create() or it had to be done in the caller. My bet is the caller. 128void *squashfs_decompressor_setup(struct super_block *sb,

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Richard Weinberger
On Fri, Nov 22, 2013 at 10:50 PM, Geyslan Gregório Bem geys...@gmail.com wrote: Coverity caught double free possibility (CID 1130962). Just wondering, where can one find/verify such CIDs? -- Thanks, //richard -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
2013/11/22 Richard Weinberger richard.weinber...@gmail.com: On Fri, Nov 22, 2013 at 10:50 PM, Geyslan Gregório Bem geys...@gmail.com wrote: Coverity caught double free possibility (CID 1130962). Just wondering, where can one find/verify such CIDs? -- Thanks, //richard Anyone can sign in

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Phillip Lougher
On 22/11/13 21:50, Geyslan Gregório Bem wrote: Coverity caught double free possibility (CID 1130962). I can patch this, but I have to know if is correct to free comp_opts in the function squashfs_decompressor_create() or it had to be done in the caller. My bet is the caller. 128void

Re: [RFC PATCH] double free in decompressor.c

2013-11-22 Thread Geyslan Gregório Bem
2013/11/22 Phillip Lougher phil...@lougher.demon.co.uk: On 22/11/13 21:50, Geyslan Gregório Bem wrote: Coverity caught double free possibility (CID 1130962). I can patch this, but I have to know if is correct to free comp_opts in the function squashfs_decompressor_create() or it had to be