Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-09-08 Thread Lucas De Marchi
Hi, On Tue, Aug 8, 2017 at 5:09 PM, Luis R. Rodriguez wrote: > On Wed, Aug 02, 2017 at 02:12:00AM +0200, Luis R. Rodriguez wrote: >> On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: >> > diff --git a/fs/exec.c b/fs/exec.c >> > index 62175cbcc801..004bb50a01fe

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-09-08 Thread Lucas De Marchi
Hi, On Tue, Aug 8, 2017 at 5:09 PM, Luis R. Rodriguez wrote: > On Wed, Aug 02, 2017 at 02:12:00AM +0200, Luis R. Rodriguez wrote: >> On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: >> > diff --git a/fs/exec.c b/fs/exec.c >> > index 62175cbcc801..004bb50a01fe 100644 >> > ---

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-08 Thread Luis R. Rodriguez
On Wed, Aug 02, 2017 at 02:12:00AM +0200, Luis R. Rodriguez wrote: > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: > > diff --git a/fs/exec.c b/fs/exec.c > > index 62175cbcc801..004bb50a01fe 100644 > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -1644,6 +1644,9 @@ int

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-08 Thread Luis R. Rodriguez
On Wed, Aug 02, 2017 at 02:12:00AM +0200, Luis R. Rodriguez wrote: > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: > > diff --git a/fs/exec.c b/fs/exec.c > > index 62175cbcc801..004bb50a01fe 100644 > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -1644,6 +1644,9 @@ int

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-08 Thread Luis R. Rodriguez
On Mon, Aug 07, 2017 at 11:26:09AM +0100, Matt Redfearn wrote: > Hi Luis, > On 03/08/17 00:23, Luis R. Rodriguez wrote: > > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: > > > On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez > > > wrote: > > > > On Fri, Jul 21,

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-08 Thread Luis R. Rodriguez
On Mon, Aug 07, 2017 at 11:26:09AM +0100, Matt Redfearn wrote: > Hi Luis, > On 03/08/17 00:23, Luis R. Rodriguez wrote: > > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: > > > On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez > > > wrote: > > > > On Fri, Jul 21, 2017 at 03:05:20PM

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-07 Thread Matt Redfearn
Hi Luis, On 03/08/17 00:23, Luis R. Rodriguez wrote: On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: Commit 6d7964a722af ("kmod: throttle

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-07 Thread Matt Redfearn
Hi Luis, On 03/08/17 00:23, Luis R. Rodriguez wrote: On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: Commit 6d7964a722af ("kmod: throttle kmod thread limit")

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-03 Thread Luis R. Rodriguez
On Thu, Aug 03, 2017 at 05:02:40PM -0700, Kees Cook wrote: > On Wed, Aug 2, 2017 at 4:23 PM, Luis R. Rodriguez wrote: > > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: > >> On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez > >> wrote: > >> > On

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-03 Thread Luis R. Rodriguez
On Thu, Aug 03, 2017 at 05:02:40PM -0700, Kees Cook wrote: > On Wed, Aug 2, 2017 at 4:23 PM, Luis R. Rodriguez wrote: > > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: > >> On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez > >> wrote: > >> > On Fri, Jul 21, 2017 at 03:05:20PM

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-03 Thread Kees Cook
On Wed, Aug 2, 2017 at 4:23 PM, Luis R. Rodriguez wrote: > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: >> On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: >> > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: >> >> Commit

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-03 Thread Kees Cook
On Wed, Aug 2, 2017 at 4:23 PM, Luis R. Rodriguez wrote: > On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: >> On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: >> > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: >> >> Commit 6d7964a722af ("kmod: throttle kmod

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-02 Thread Luis R. Rodriguez
On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: > On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: > > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: > >> Commit 6d7964a722af ("kmod: throttle kmod thread limit") which was > >> merged in

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-02 Thread Luis R. Rodriguez
On Tue, Aug 01, 2017 at 07:28:20PM -0700, Kees Cook wrote: > On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: > > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: > >> Commit 6d7964a722af ("kmod: throttle kmod thread limit") which was > >> merged in v4.13-rc1 broke this

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-01 Thread Kees Cook
On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: >> Commit 6d7964a722af ("kmod: throttle kmod thread limit") which was >> merged in v4.13-rc1 broke this behaviour since the recursive modprobe is >> no

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-01 Thread Kees Cook
On Tue, Aug 1, 2017 at 5:12 PM, Luis R. Rodriguez wrote: > On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: >> Commit 6d7964a722af ("kmod: throttle kmod thread limit") which was >> merged in v4.13-rc1 broke this behaviour since the recursive modprobe is >> no longer caught, it just

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-01 Thread Luis R. Rodriguez
On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: > When the kernel does not have a binary format handler for an executable > it is attempting to load, when CONFIG_MODULES is enabled it will attempt > to load a module for that format. If the kernel does not have a binary > format

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-08-01 Thread Luis R. Rodriguez
On Fri, Jul 21, 2017 at 03:05:20PM +0100, Matt Redfearn wrote: > When the kernel does not have a binary format handler for an executable > it is attempting to load, when CONFIG_MODULES is enabled it will attempt > to load a module for that format. If the kernel does not have a binary > format

[RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-07-21 Thread Matt Redfearn
When the kernel does not have a binary format handler for an executable it is attempting to load, when CONFIG_MODULES is enabled it will attempt to load a module for that format. If the kernel does not have a binary format handler for the modprobe executable, this will trigger another module load.

[RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-07-21 Thread Matt Redfearn
When the kernel does not have a binary format handler for an executable it is attempting to load, when CONFIG_MODULES is enabled it will attempt to load a module for that format. If the kernel does not have a binary format handler for the modprobe executable, this will trigger another module load.