Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread David Miller
From: Harish Jenny Kandiga Nagaraj Date: Wed, 3 Sep 2014 10:49:59 +0530 > If that is the case , then subscriptions of netlink_sock should have > been updated after netlink_remove or netlink_release. I don't see > that happening. Please do not top-post. First provide the quoted context, then

Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread Harish Jenny Kandiga Nagaraj
If that is the case , then subscriptions of netlink_sock should have been updated after netlink_remove or netlink_release. I don't see that happening. On Wednesday 03 September 2014 12:22 AM, David Miller wrote: > From: Harish Jenny Kandiga Nagaraj > Date: Tue, 2 Sep 2014 14:14:38 +0530 > >> In

Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread David Miller
From: Harish Jenny Kandiga Nagaraj Date: Tue, 2 Sep 2014 14:14:38 +0530 > In one of our random test runs we observed the crash mentioned in the > previous mail. > > After debugging we found out that the call flow of the inline and static > functions were > netlink_release >

Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread Harish Jenny Kandiga Nagaraj
In one of our random test runs we observed the crash mentioned in the previous mail. After debugging we found out that the call flow of the inline and static functions were netlink_release -netlink_remove -__sk_del_bind_node --__hlist_del *pprev was NULL in __hlist_del

Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread Harish Jenny Kandiga Nagaraj
In one of our random test runs we observed the crash mentioned in the previous mail. After debugging we found out that the call flow of the inline and static functions were netlink_release -netlink_remove -__sk_del_bind_node --__hlist_del *pprev was NULL in __hlist_del

Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread David Miller
From: Harish Jenny Kandiga Nagaraj harish_kand...@mentor.com Date: Tue, 2 Sep 2014 14:14:38 +0530 In one of our random test runs we observed the crash mentioned in the previous mail. After debugging we found out that the call flow of the inline and static functions were netlink_release

Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread Harish Jenny Kandiga Nagaraj
If that is the case , then subscriptions of netlink_sock should have been updated after netlink_remove or netlink_release. I don't see that happening. On Wednesday 03 September 2014 12:22 AM, David Miller wrote: From: Harish Jenny Kandiga Nagaraj harish_kand...@mentor.com Date: Tue, 2 Sep 2014

Re: [RFC PATCH] netlink: Safer deletion of sk_bind_node

2014-09-02 Thread David Miller
From: Harish Jenny Kandiga Nagaraj harish_kand...@mentor.com Date: Wed, 3 Sep 2014 10:49:59 +0530 If that is the case , then subscriptions of netlink_sock should have been updated after netlink_remove or netlink_release. I don't see that happening. Please do not top-post. First provide the