Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-17 Thread Miklos Szeredi
On Fri, Nov 14, 2014 at 9:55 AM, Jordi Pujol Palomer wrote: > EL Mon, 10 Nov 2014 10:09:54 +0100 > Miklos Szeredi escrigué: > >> Maybe it wasn't clear, but the number of lower layers isn't limited by >> FILESYSTEM_MAX_STACK_DEPTH, > sorry, you have been clear, it's me that have not explained the

Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-17 Thread Miklos Szeredi
On Fri, Nov 14, 2014 at 9:55 AM, Jordi Pujol Palomer jordipuj...@gmail.com wrote: EL Mon, 10 Nov 2014 10:09:54 +0100 Miklos Szeredi mik...@szeredi.hu escrigué: Maybe it wasn't clear, but the number of lower layers isn't limited by FILESYSTEM_MAX_STACK_DEPTH, sorry, you have been clear, it's

Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-14 Thread Jordi Pujol Palomer
EL Mon, 10 Nov 2014 10:09:54 +0100 Miklos Szeredi escrigué: > Maybe it wasn't clear, but the number of lower layers isn't limited by > FILESYSTEM_MAX_STACK_DEPTH, sorry, you have been clear, it's me that have not explained the purpose of that patch. This idea is also valid for the main

Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-14 Thread Jordi Pujol Palomer
EL Mon, 10 Nov 2014 10:09:54 +0100 Miklos Szeredi mik...@szeredi.hu escrigué: Maybe it wasn't clear, but the number of lower layers isn't limited by FILESYSTEM_MAX_STACK_DEPTH, sorry, you have been clear, it's me that have not explained the purpose of that patch. This idea is also valid for

Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-10 Thread Erez Zadok
Indeed, Miklos, changing layers dynamically is VERY tricky. Unionfs supports that, but a good amount of its code all over is dedicated to handling dynamic layer changes. I advise you to avoid supporting this feature for a while, if ever: get a small, functional, working overlayfs first. I

Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-10 Thread Miklos Szeredi
Thanks to everyone for testing. Here's an updated patch to fix the statfs Oops. Maybe it wasn't clear, but the number of lower layers isn't limited by FILESYSTEM_MAX_STACK_DEPTH, only by the max size of the mount option buffer in the kernel (1 page, usually 4096bytes). So you could have a

Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-10 Thread Miklos Szeredi
Thanks to everyone for testing. Here's an updated patch to fix the statfs Oops. Maybe it wasn't clear, but the number of lower layers isn't limited by FILESYSTEM_MAX_STACK_DEPTH, only by the max size of the mount option buffer in the kernel (1 page, usually 4096bytes). So you could have a

Re: [RFC PATCH] overlayfs: support more than one read-only layer

2014-11-10 Thread Erez Zadok
Indeed, Miklos, changing layers dynamically is VERY tricky. Unionfs supports that, but a good amount of its code all over is dedicated to handling dynamic layer changes. I advise you to avoid supporting this feature for a while, if ever: get a small, functional, working overlayfs first. I