Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-10 Thread Vincent Guittot
On 9 April 2013 20:52, Vincent Guittot vincent.guit...@linaro.org wrote: On Tuesday, 9 April 2013, Lukasz Majewski l.majew...@samsung.com wrote: Hi Viresh and Vincent, On 9 April 2013 16:07, Lukasz Majewski l.majew...@samsung.com wrote: On Mon, Apr 1, 2013 at 1:54 PM, Jonghwa Lee Our

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-10 Thread Lukasz Majewski
Hi Vincent, On Tuesday, 9 April 2013, Lukasz Majewski l.majew...@samsung.com wrote: Hi Viresh and Vincent, On 9 April 2013 16:07, Lukasz Majewski l.majew...@samsung.com wrote: On Mon, Apr 1, 2013 at 1:54 PM, Jonghwa Lee Our approach is a bit different than cpufreq_ondemand

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-10 Thread Vincent Guittot
On 10 April 2013 10:44, Lukasz Majewski l.majew...@samsung.com wrote: Hi Vincent, On Tuesday, 9 April 2013, Lukasz Majewski l.majew...@samsung.com wrote: Hi Viresh and Vincent, On 9 April 2013 16:07, Lukasz Majewski l.majew...@samsung.com wrote: On Mon, Apr 1, 2013 at 1:54 PM,

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-10 Thread Lukasz Majewski
Hi Vincent, On 10 April 2013 10:44, Lukasz Majewski l.majew...@samsung.com wrote: Hi Vincent, On Tuesday, 9 April 2013, Lukasz Majewski l.majew...@samsung.com wrote: Hi Viresh and Vincent, On 9 April 2013 16:07, Lukasz Majewski l.majew...@samsung.com wrote: On Mon,

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-10 Thread Lorenzo Pieralisi
On Wed, Apr 10, 2013 at 09:44:52AM +0100, Lukasz Majewski wrote: [...] Have you also looked at the power clamp driver that have similar target ? I might be wrong here, but in my opinion the power clamp driver is a bit different: 1. It is dedicated to Intel SoCs, which provide special

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-10 Thread Vincent Guittot
On 10 April 2013 11:38, Lukasz Majewski l.majew...@samsung.com wrote: Hi Vincent, On 10 April 2013 10:44, Lukasz Majewski l.majew...@samsung.com wrote: Hi Vincent, On Tuesday, 9 April 2013, Lukasz Majewski l.majew...@samsung.com wrote: Hi Viresh and Vincent, On 9 April

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-09 Thread Lukasz Majewski
Hi Viresh, First of all I'd like to apologize for a late response. Please find my comments below. On Mon, Apr 1, 2013 at 1:54 PM, Jonghwa Lee jonghwa3@samsung.com wrote: Purpose One of the problem of ondemand is that it considers the most busy cpu only while doesn't care how many

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-09 Thread Viresh Kumar
On 9 April 2013 16:07, Lukasz Majewski l.majew...@samsung.com wrote: On Mon, Apr 1, 2013 at 1:54 PM, Jonghwa Lee Our approach is a bit different than cpufreq_ondemand one. Ondemand takes the per CPU idle time, then on that basis calculates per cpu load. The next step is to choose the highest

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-09 Thread jonghwa3 . lee
Hi, sorry for my late reply. I just want to add comment to assist Lukasz's. I put my comments below of Lukasz's. On 2013년 04월 09일 19:37, Lukasz Majewski wrote: Hi Viresh, First of all I'd like to apologize for a late response. Please find my comments below. On Mon, Apr 1, 2013 at 1:54

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-09 Thread Lukasz Majewski
Hi Viresh and Vincent, On 9 April 2013 16:07, Lukasz Majewski l.majew...@samsung.com wrote: On Mon, Apr 1, 2013 at 1:54 PM, Jonghwa Lee Our approach is a bit different than cpufreq_ondemand one. Ondemand takes the per CPU idle time, then on that basis calculates per cpu load. The next

[RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-01 Thread Jonghwa Lee
This patchset adds new cpufreq governor named LAB(Legacy Application Boost). Basically, this governor is based on ondemand governor. ** Introduce LAB (Legacy Application Boost) governor Purpose One of the problem of ondemand is that it considers the most busy cpu only while doesn't care how

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-01 Thread Viresh Kumar
On Mon, Apr 1, 2013 at 1:54 PM, Jonghwa Lee jonghwa3@samsung.com wrote: Purpose One of the problem of ondemand is that it considers the most busy cpu only while doesn't care how many cpu is in busy state at the moment. This may results in unnecessary power consumption, and it'll be