Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-19 Thread Mark Brown
On Fri, Apr 16, 2021 at 02:39:25PM -0500, Pierre-Louis Bossart wrote: > On 4/16/21 1:55 PM, Mark Brown wrote: > > to the maximum supported bit width for internal operation so bit width > > only matters on external interfaces) but I think for a first pass we can > > get away with forcing

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Pierre-Louis Bossart
On 4/16/21 1:55 PM, Mark Brown wrote: On Fri, Apr 16, 2021 at 11:47:01AM -0500, Pierre-Louis Bossart wrote: On 4/16/21 11:31 AM, Mark Brown wrote: Not really written down that I can think of. I think the next steps that I can think of right now are unfortunately bigger and harder ones,

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 11:47:01AM -0500, Pierre-Louis Bossart wrote: > On 4/16/21 11:31 AM, Mark Brown wrote: > > Not really written down that I can think of. I think the next steps > > that I can think of right now are unfortunately bigger and harder ones, > > mainly working out a way to

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Pierre-Louis Bossart
On 4/16/21 11:31 AM, Mark Brown wrote: On Fri, Apr 16, 2021 at 04:03:05PM +, codrin.ciubota...@microchip.com wrote: Thank you for the links! So basically the machine driver disappears and all the components will be visible in user-space. Not entirely - you still need something to say

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Codrin.Ciubotariu
On 16.04.2021 19:31, Mark Brown wrote: > On Fri, Apr 16, 2021 at 04:03:05PM +, codrin.ciubota...@microchip.com > wrote: > >> Thank you for the links! So basically the machine driver disappears and >> all the components will be visible in user-space. > > Not entirely - you still need

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 04:03:05PM +, codrin.ciubota...@microchip.com wrote: > Thank you for the links! So basically the machine driver disappears and > all the components will be visible in user-space. Not entirely - you still need something to say how they're wired together but it'll be a

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Codrin.Ciubotariu
On 15.04.2021 20:25, Mark Brown wrote: > On Thu, Apr 15, 2021 at 04:56:00PM +, codrin.ciubota...@microchip.com > wrote: > >> Are there any plans for refactoring DPCM? any ideas ongoing? I also have >> some changes for PCM dmaengine, in the same 'style', similar to what I >> sent some time

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-15 Thread Mark Brown
On Thu, Apr 15, 2021 at 04:56:00PM +, codrin.ciubota...@microchip.com wrote: > Are there any plans for refactoring DPCM? any ideas ongoing? I also have > some changes for PCM dmaengine, in the same 'style', similar to what I > sent some time ago... > I can adjust to different ideas, if

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-15 Thread Codrin.Ciubotariu
On 15.04.2021 19:17, Mark Brown wrote: > On Wed, Apr 14, 2021 at 02:58:10PM +, codrin.ciubota...@microchip.com > wrote: > >> How about using a different API for ASoC only, since that's the place of >> DPCM. Only drivers that do not involve DSPs would have to to be changed >> to call the new

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-15 Thread Mark Brown
On Wed, Apr 14, 2021 at 02:58:10PM +, codrin.ciubota...@microchip.com wrote: > How about using a different API for ASoC only, since that's the place of > DPCM. Only drivers that do not involve DSPs would have to to be changed > to call the new snd_pcm_hw_rule_add() variant. > Another

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-14 Thread Codrin.Ciubotariu
On 23.03.2021 16:18, codrin.ciubota...@microchip.com wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 23.03.2021 14:15, Jaroslav Kysela wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-24 Thread Codrin.Ciubotariu
On 24.03.2021 17:28, Pierre-Louis Bossart wrote: >> I am using hw_params_fixup, but it's not enough. The first thing I do is >> to not add the BE HW constraint rules in runtime->hw_constraints, >> because this will potentially affect the FE HW params. If the FE does >> sampling rate conversion,

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-24 Thread Pierre-Louis Bossart
I am using hw_params_fixup, but it's not enough. The first thing I do is to not add the BE HW constraint rules in runtime->hw_constraints, because this will potentially affect the FE HW params. If the FE does sampling rate conversion, for example, applying the sampling rate constrain rules

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-24 Thread Codrin.Ciubotariu
On 23.03.2021 21:25, Pierre-Louis Bossart wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know > the content is safe > > On 3/23/21 6:43 AM, Codrin Ciubotariu wrote: >> HW constraints are needed to set limitations for HW parameters used to >> configure the DAIs. All

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-23 Thread Pierre-Louis Bossart
On 3/23/21 6:43 AM, Codrin Ciubotariu wrote: HW constraints are needed to set limitations for HW parameters used to configure the DAIs. All DAIs on the same link must agree upon the HW parameters, so the parameters are affected by the DAIs' features and their limitations. In case of DPCM, the

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-23 Thread Codrin.Ciubotariu
On 23.03.2021 14:15, Jaroslav Kysela wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Dne 23. 03. 21 v 12:43 Codrin Ciubotariu napsal(a): > >> To achieve this, the first thing needed is to detect whether a HW >> constraint rule is

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-23 Thread Jaroslav Kysela
Dne 23. 03. 21 v 12:43 Codrin Ciubotariu napsal(a): > To achieve this, the first thing needed is to detect whether a HW > constraint rule is enforced by a FE or a BE DAI. This means that > snd_pcm_hw_rule_add() needs to be able to differentiate between the two > type of DAIs. For this, the

[RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-23 Thread Codrin Ciubotariu
HW constraints are needed to set limitations for HW parameters used to configure the DAIs. All DAIs on the same link must agree upon the HW parameters, so the parameters are affected by the DAIs' features and their limitations. In case of DPCM, the FE DAIs can be used to perform different kind of