Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-18 Thread Dmitry Safonov
On Thu, 2018-01-18 at 05:09 +0100, Frederic Weisbecker wrote: > On Wed, Jan 17, 2018 at 07:09:39PM -0800, Linus Torvalds wrote: > > It should never trigger under any normal load, but I think it > > *should* > > trigger under the load that the networking people worry about. If > > you > > get a floo

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Frederic Weisbecker
On Wed, Jan 17, 2018 at 07:09:39PM -0800, Linus Torvalds wrote: > On Wed, Jan 17, 2018 at 6:55 PM, Frederic Weisbecker > wrote: > >> I thought you were going to actally account for time, but I don't > >> think you ended up doing that. > > > > I did in the first version but then I thought you sugge

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Linus Torvalds
On Wed, Jan 17, 2018 at 6:55 PM, Frederic Weisbecker wrote: >> I thought you were going to actally account for time, but I don't >> think you ended up doing that. > > I did in the first version but then I thought you suggested that count per > jiffy. I probably misunderstood :) Oh, miscommunicati

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Frederic Weisbecker
On Wed, Jan 17, 2018 at 03:56:43PM -0800, Linus Torvalds wrote: > On Wed, Jan 17, 2018 at 10:07 AM, Frederic Weisbecker > wrote: > > > > I see, so you may want to test (possibly much) higher values of > > MAX_SOFTIRQ_RESTART, > > such as 50 or 100. > > I suspect the "number of softiqs per jiffy"

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Linus Torvalds
On Wed, Jan 17, 2018 at 10:07 AM, Frederic Weisbecker wrote: > > I see, so you may want to test (possibly much) higher values of > MAX_SOFTIRQ_RESTART, > such as 50 or 100. I suspect the "number of softiqs per jiffy" is hardly interesting at all. We used to allow up to 2mS or ten iterations per

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Frederic Weisbecker
Hi Mauro, On Wed, Jan 17, 2018 at 02:56:20PM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 16 Jan 2018 05:40:35 +0100 > Frederic Weisbecker escreveu: > > > So this set is in a testable state. I addressed preliminary reviews from > > Eric Dumazet, Paolo Abeni and Linus. > > > > You may want to p

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Mauro Carvalho Chehab
Em Tue, 16 Jan 2018 05:40:35 +0100 Frederic Weisbecker escreveu: > So this set is in a testable state. I addressed preliminary reviews from > Eric Dumazet, Paolo Abeni and Linus. > > You may want to play with MAX_SOFTIRQ_RESTART value, which is now the > number of calls allowed for a vector in a

[RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-15 Thread Frederic Weisbecker
So this set is in a testable state. I addressed preliminary reviews from Eric Dumazet, Paolo Abeni and Linus. You may want to play with MAX_SOFTIRQ_RESTART value, which is now the number of calls allowed for a vector in a jiffy frame before it gets queued to the workqueue. I set it to the arbitrar