Re: [RFC PATCH 0/5] watchdog: Add reboot API
Am Donnerstag, 1. Mai 2014, 08:41:28 schrieb Guenter Roeck: > Some hardware implements reboot through its watchdog hardware, for example > by triggering a watchdog timeout or by writing into its watchdog register > set. Platform specific code starts to spread into watchdog drivers, > typically by setting pointers to a callback function which is then called > from the architecture's reset handler. > > While global and exported callback function pointers (such as > arm_pm_restart) may be acceptable as long as they are used from platform > and/or architecture code, using such a mechanism across subsystems and > drivers is less than desirable. Ultimately, we'll need a better solution. > > This patch series is an attempt to provide such a solution. It extends > the watchdog subsystem to support reboot functionality, provides an > API function call to trigger reboots, adds support for the new API > to arm and arm64, and converts the drivers providing reboot functionality > to use the new infrastructure. > > The first patch in the series implements the new API. The second and third > patch modify the arm and arm64 architecture reset handlers to call the > added API function. The final two patches register the reboot handlers > in the sunxi and moxart watchdog drivers with the watchdog subsystem. > > The sunxi patche depends on the most recent patch series sumitted by > Maxime Ripard. a lot of Samsung architectures use a watchdog based reset too (among them some of the s3c24xx I care about) and this series looks really great for this, so Acked-by: Heiko Stuebner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 0/5] watchdog: Add reboot API
Am Donnerstag, 1. Mai 2014, 08:41:28 schrieb Guenter Roeck: Some hardware implements reboot through its watchdog hardware, for example by triggering a watchdog timeout or by writing into its watchdog register set. Platform specific code starts to spread into watchdog drivers, typically by setting pointers to a callback function which is then called from the architecture's reset handler. While global and exported callback function pointers (such as arm_pm_restart) may be acceptable as long as they are used from platform and/or architecture code, using such a mechanism across subsystems and drivers is less than desirable. Ultimately, we'll need a better solution. This patch series is an attempt to provide such a solution. It extends the watchdog subsystem to support reboot functionality, provides an API function call to trigger reboots, adds support for the new API to arm and arm64, and converts the drivers providing reboot functionality to use the new infrastructure. The first patch in the series implements the new API. The second and third patch modify the arm and arm64 architecture reset handlers to call the added API function. The final two patches register the reboot handlers in the sunxi and moxart watchdog drivers with the watchdog subsystem. The sunxi patche depends on the most recent patch series sumitted by Maxime Ripard. a lot of Samsung architectures use a watchdog based reset too (among them some of the s3c24xx I care about) and this series looks really great for this, so Acked-by: Heiko Stuebner he...@sntech.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 0/5] watchdog: Add reboot API
Thanks, Applied in series: 1, 3, and 4 Patches work on moxa UC-7112-LX hardware. Tested-by: Jonas Jensen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 0/5] watchdog: Add reboot API
Thanks, Applied in series: 1, 3, and 4 Patches work on moxa UC-7112-LX hardware. Tested-by: Jonas Jensen jonas.jen...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 0/5] watchdog: Add reboot API
On Thursday 01 May 2014, Guenter Roeck wrote: > > Some hardware implements reboot through its watchdog hardware, for example > by triggering a watchdog timeout or by writing into its watchdog register > set. Platform specific code starts to spread into watchdog drivers, > typically by setting pointers to a callback function which is then called > from the architecture's reset handler. Looks very nice to me, thanks for starting this! Acked-by: Arnd Bergmann Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 0/5] watchdog: Add reboot API
On Thursday 01 May 2014, Guenter Roeck wrote: Some hardware implements reboot through its watchdog hardware, for example by triggering a watchdog timeout or by writing into its watchdog register set. Platform specific code starts to spread into watchdog drivers, typically by setting pointers to a callback function which is then called from the architecture's reset handler. Looks very nice to me, thanks for starting this! Acked-by: Arnd Bergmann a...@arndb.de Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RFC PATCH 0/5] watchdog: Add reboot API
Some hardware implements reboot through its watchdog hardware, for example by triggering a watchdog timeout or by writing into its watchdog register set. Platform specific code starts to spread into watchdog drivers, typically by setting pointers to a callback function which is then called from the architecture's reset handler. While global and exported callback function pointers (such as arm_pm_restart) may be acceptable as long as they are used from platform and/or architecture code, using such a mechanism across subsystems and drivers is less than desirable. Ultimately, we'll need a better solution. This patch series is an attempt to provide such a solution. It extends the watchdog subsystem to support reboot functionality, provides an API function call to trigger reboots, adds support for the new API to arm and arm64, and converts the drivers providing reboot functionality to use the new infrastructure. The first patch in the series implements the new API. The second and third patch modify the arm and arm64 architecture reset handlers to call the added API function. The final two patches register the reboot handlers in the sunxi and moxart watchdog drivers with the watchdog subsystem. The sunxi patche depends on the most recent patch series sumitted by Maxime Ripard. Compile tested only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RFC PATCH 0/5] watchdog: Add reboot API
Some hardware implements reboot through its watchdog hardware, for example by triggering a watchdog timeout or by writing into its watchdog register set. Platform specific code starts to spread into watchdog drivers, typically by setting pointers to a callback function which is then called from the architecture's reset handler. While global and exported callback function pointers (such as arm_pm_restart) may be acceptable as long as they are used from platform and/or architecture code, using such a mechanism across subsystems and drivers is less than desirable. Ultimately, we'll need a better solution. This patch series is an attempt to provide such a solution. It extends the watchdog subsystem to support reboot functionality, provides an API function call to trigger reboots, adds support for the new API to arm and arm64, and converts the drivers providing reboot functionality to use the new infrastructure. The first patch in the series implements the new API. The second and third patch modify the arm and arm64 architecture reset handlers to call the added API function. The final two patches register the reboot handlers in the sunxi and moxart watchdog drivers with the watchdog subsystem. The sunxi patche depends on the most recent patch series sumitted by Maxime Ripard. Compile tested only. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
