Re: [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-29 Thread Atish Patra
On Sat, Jun 27, 2020 at 2:22 AM Ard Biesheuvel wrote: > > On Sat, 27 Jun 2020 at 00:03, Ard Biesheuvel wrote: > > > > On Fri, 26 Jun 2020 at 23:56, Atish Patra wrote: > > > > > > On Thu, Jun 25, 2020 at 7:43 PM Heinrich Schuchardt > > > wrote: > > > > > > > > On 6/26/20 1:45 AM, Atish Patra

Re: [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-27 Thread Ard Biesheuvel
On Sat, 27 Jun 2020 at 00:03, Ard Biesheuvel wrote: > > On Fri, 26 Jun 2020 at 23:56, Atish Patra wrote: > > > > On Thu, Jun 25, 2020 at 7:43 PM Heinrich Schuchardt > > wrote: > > > > > > On 6/26/20 1:45 AM, Atish Patra wrote: > > > > 32bit gcc doesn't support modulo operation on 64 bit data.

Re: [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-26 Thread Ard Biesheuvel
On Fri, 26 Jun 2020 at 23:56, Atish Patra wrote: > > On Thu, Jun 25, 2020 at 7:43 PM Heinrich Schuchardt > wrote: > > > > On 6/26/20 1:45 AM, Atish Patra wrote: > > > 32bit gcc doesn't support modulo operation on 64 bit data. It results in > > > a __umoddi3 error while building EFI for 32 bit.

Re: [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-26 Thread Atish Patra
On Thu, Jun 25, 2020 at 7:43 PM Heinrich Schuchardt wrote: > > On 6/26/20 1:45 AM, Atish Patra wrote: > > 32bit gcc doesn't support modulo operation on 64 bit data. It results in > > a __umoddi3 error while building EFI for 32 bit. > > > > Use bitwise operations instead of modulo operations to

Re: [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-25 Thread Heinrich Schuchardt
On 6/26/20 1:45 AM, Atish Patra wrote: > 32bit gcc doesn't support modulo operation on 64 bit data. It results in > a __umoddi3 error while building EFI for 32 bit. > > Use bitwise operations instead of modulo operations to fix the issue. > > Signed-off-by: Atish Patra > --- >

[RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-25 Thread Atish Patra
32bit gcc doesn't support modulo operation on 64 bit data. It results in a __umoddi3 error while building EFI for 32 bit. Use bitwise operations instead of modulo operations to fix the issue. Signed-off-by: Atish Patra --- drivers/firmware/efi/libstub/alignedmem.c | 2 +- 1 file changed, 1