Re: [RFC PATCH 07/13] sched: Add core wide task selection and scheduling.

2020-05-22 Thread Joel Fernandes
On Fri, May 22, 2020 at 11:44:06AM +0800, Aaron Lu wrote: [...] > > Updated diff below: > > > > ---8<--- > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 005d7f7323e2d..625377f393ed3 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c >

Re: [RFC PATCH 07/13] sched: Add core wide task selection and scheduling.

2020-05-21 Thread Aaron Lu
On Thu, May 21, 2020 at 10:35:56PM -0400, Joel Fernandes wrote: > Discussed a lot with Vineeth. Below is an improved version of the pick_task() > similification. > > It also handles the following "bug" in the existing code as well that Vineeth > brought up in OSPM: Suppose 2 siblings of a core:

Re: [RFC PATCH 07/13] sched: Add core wide task selection and scheduling.

2020-05-21 Thread Joel Fernandes
On Thu, May 21, 2020 at 07:14:26PM -0400, Joel Fernandes wrote: > On Wed, Mar 04, 2020 at 04:59:57PM +, vpillai wrote: > > From: Peter Zijlstra > > > > Instead of only selecting a local task, select a task for all SMT > > siblings for every reschedule on the core (irrespective which logical

Re: [RFC PATCH 07/13] sched: Add core wide task selection and scheduling.

2020-05-21 Thread Joel Fernandes
On Thu, May 21, 2020 at 07:14:26PM -0400, Joel Fernandes wrote: > On Wed, Mar 04, 2020 at 04:59:57PM +, vpillai wrote: [snip] > > + /* > > +* If class_pick is idle or matches cookie, return early. > > +*/ > > + if (cookie_equals(class_pick, cookie)) > > + return

Re: [RFC PATCH 07/13] sched: Add core wide task selection and scheduling.

2020-05-21 Thread Joel Fernandes
On Wed, Mar 04, 2020 at 04:59:57PM +, vpillai wrote: > From: Peter Zijlstra > > Instead of only selecting a local task, select a task for all SMT > siblings for every reschedule on the core (irrespective which logical > CPU does the reschedule). > > There could be races in core scheduler