On 30/04/2018 11:46, Lee Jones wrote:
On Mon, 30 Apr 2018, John Garry wrote:
So we using the mfd_cell to match child devices using _HID. At a glance, I
don't actually see other drivers to use mfd_cell_acpi_match.pnpid .
Anyway we don't use static tables as we need to update the resources of th
On Mon, 30 Apr 2018, John Garry wrote:
> > > > > So we using the mfd_cell to match child devices using _HID. At a
> > > > > glance, I
> > > > > don't actually see other drivers to use mfd_cell_acpi_match.pnpid .
> > > > >
> > > > > Anyway we don't use static tables as we need to update the resou
So we using the mfd_cell to match child devices using _HID. At a glance, I
don't actually see other drivers to use mfd_cell_acpi_match.pnpid .
Anyway we don't use static tables as we need to update the resources of the
cell dynamically. However I do look at a driver like intel_quark_i2c_gpio.c,
a
On Mon, 30 Apr 2018, John Garry wrote:
> On 30/04/2018 06:36, Lee Jones wrote:
> > On Fri, 27 Apr 2018, John Garry wrote:
> > > On 26/04/2018 15:23, John Garry wrote:
> > > > On 26/04/2018 15:08, Mika Westerberg wrote:
> > > > > On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
> > > > >
On 30/04/2018 06:36, Lee Jones wrote:
On Fri, 27 Apr 2018, John Garry wrote:
On 26/04/2018 15:23, John Garry wrote:
On 26/04/2018 15:08, Mika Westerberg wrote:
On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
index 2d4611
On Fri, 27 Apr 2018, John Garry wrote:
> On 26/04/2018 15:23, John Garry wrote:
> > On 26/04/2018 15:08, Mika Westerberg wrote:
> > > On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
> > > > diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> > > > index 2d4611e..b04425b 10064
On 26/04/2018 15:23, John Garry wrote:
+
On 26/04/2018 15:08, Mika Westerberg wrote:
On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
index 2d4611e..b04425b 100644
--- a/drivers/bus/hisi_lpc.c
+++ b/drivers/bus/hisi_lpc.c
On Thu, Apr 26, 2018 at 03:23:17PM +0100, John Garry wrote:
> Not that I know about. Can you describe this method? I guess I also don't
> need to set the mfd_cell pnpid either for this special case device.
There is some documentation in "MFD devices" chapter of
Documentation/acpi/enumeration.txt a
On 26/04/2018 15:08, Mika Westerberg wrote:
On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
index 2d4611e..b04425b 100644
--- a/drivers/bus/hisi_lpc.c
+++ b/drivers/bus/hisi_lpc.c
@@ -18,6 +18,8 @@
#include
#include
#i
On Thu, Apr 26, 2018 at 02:49:49PM +0100, John Garry wrote:
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 2d4611e..b04425b 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -18,6 +18,8 @@
> #include
> #include
> #include
> +#include
> +#includ
On 20/04/2018 15:09, John Garry wrote:
On 20/04/2018 14:52, Mika Westerberg wrote:
On Fri, Apr 20, 2018 at 02:24:18PM +0100, John Garry wrote:
Hi Mika,
On 20/04/2018 14:07, Mika Westerberg wrote:
On Fri, Apr 20, 2018 at 06:07:25PM +0800, John Garry wrote:
+} else {
+device->drive
On 20/04/2018 14:52, Mika Westerberg wrote:
On Fri, Apr 20, 2018 at 02:24:18PM +0100, John Garry wrote:
Hi Mika,
On 20/04/2018 14:07, Mika Westerberg wrote:
On Fri, Apr 20, 2018 at 06:07:25PM +0800, John Garry wrote:
+ } else {
+ device->driver_data = dev;
I think this d
On Fri, Apr 20, 2018 at 02:24:18PM +0100, John Garry wrote:
> Hi Mika,
>
> On 20/04/2018 14:07, Mika Westerberg wrote:
> > On Fri, Apr 20, 2018 at 06:07:25PM +0800, John Garry wrote:
> > > + } else {
> > > + device->driver_data = dev;
> >
> > I think this deserves a comment explaining why
Hi Mika,
On 20/04/2018 14:07, Mika Westerberg wrote:
On Fri, Apr 20, 2018 at 06:07:25PM +0800, John Garry wrote:
+ } else {
+ device->driver_data = dev;
I think this deserves a comment explaining why we (ab)use driver_data
like this.
Sure, could add. I didn't see any oth
On Fri, Apr 20, 2018 at 06:07:25PM +0800, John Garry wrote:
> + } else {
> + device->driver_data = dev;
I think this deserves a comment explaining why we (ab)use driver_data
like this.
For ACPI devices with the enumeration_by_parent flag set,
we expect the parent device to enumerate the device after
the ACPI scan.
This patch does partially the same for devices which are
enumerated as PNP devices.
We still want PNP scan code to create the per-ACPI device
PNP device, but hold off
16 matches
Mail list logo
