Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2013-01-09 Thread Matt Porter
On Wed, Oct 24, 2012 at 08:43:27AM +0530, Vinod Koul wrote: > On Tue, 2012-10-23 at 23:49 +0100, Grant Likely wrote: > > > +enum dmaengine_apis { > > > + DMAENGINE_MEMCPY= 0x0001, > > > + DMAENGINE_XOR = 0x0002, > > > + DMAENGINE_XOR_VAL = 0x0004, > > > +

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Vinod Koul
On Tue, 2012-10-23 at 23:49 +0100, Grant Likely wrote: > > +enum dmaengine_apis { > > + DMAENGINE_MEMCPY= 0x0001, > > + DMAENGINE_XOR = 0x0002, > > + DMAENGINE_XOR_VAL = 0x0004, > > + DMAENGINE_PQ= 0x0008, > > + DMAENGINE_PQ_VAL

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Vinod Koul
On Tue, 2012-10-23 at 15:54 -0700, Dan Williams wrote: > > +struct dmaengine_chan_caps { > > + enum dmaengine_apis ops; > > + int seg_nr; > > + int seg_len; > > +}; > > This makes sense for the potentially dynamic capability properties > that get set after configuration, but why

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Dan Williams
On Thu, Oct 18, 2012 at 7:51 PM, Matt Porter wrote: > Add a dmaengine API to retrieve per channel capabilities. > Currently, only channel ops and SG segment limitations are > implemented caps. > > The API is optionally implemented by drivers and when > unimplemented will return a NULL pointer. It

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Grant Likely
On Fri, Oct 19, 2012 at 3:51 AM, Matt Porter wrote: > Add a dmaengine API to retrieve per channel capabilities. > Currently, only channel ops and SG segment limitations are > implemented caps. > > The API is optionally implemented by drivers and when > unimplemented will return a NULL pointer. It

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Grant Likely
On Fri, Oct 19, 2012 at 3:51 AM, Matt Porter wrote: > Add a dmaengine API to retrieve per channel capabilities. > Currently, only channel ops and SG segment limitations are > implemented caps. > > The API is optionally implemented by drivers and when > unimplemented will return a NULL pointer. It

[RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-18 Thread Matt Porter
Add a dmaengine API to retrieve per channel capabilities. Currently, only channel ops and SG segment limitations are implemented caps. The API is optionally implemented by drivers and when unimplemented will return a NULL pointer. It is intended to be executed after a channel has been requested an