Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-28 Thread Linus Walleij
On Tue, Aug 27, 2013 at 11:33 PM, Stephen Warren wrote: > On 08/27/2013 01:42 AM, Nicolas Ferre wrote: >> The question is: how much this "generic" pinconf is... well... generic! > > This is why I don't really like the concept of generic pinconf; it ends > up being more: whoever defines something

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-28 Thread Linus Walleij
On Tue, Aug 27, 2013 at 9:42 AM, Nicolas Ferre wrote: > On 27/08/2013 08:16, boris brezillon : > Deglitch and > Debounce filters are different features in at91 (even if they pursuit the > same goal). So I do prefer to let the user choose which feature is preferred > for his application and add a

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-28 Thread Linus Walleij
On Tue, Aug 27, 2013 at 9:42 AM, Nicolas Ferre nicolas.fe...@atmel.com wrote: On 27/08/2013 08:16, boris brezillon : Deglitch and Debounce filters are different features in at91 (even if they pursuit the same goal). So I do prefer to let the user choose which feature is preferred for his

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-28 Thread Linus Walleij
On Tue, Aug 27, 2013 at 11:33 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2013 01:42 AM, Nicolas Ferre wrote: The question is: how much this generic pinconf is... well... generic! This is why I don't really like the concept of generic pinconf; it ends up being more: whoever

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread Stephen Warren
On 08/27/2013 01:42 AM, Nicolas Ferre wrote: > On 27/08/2013 08:16, boris brezillon : >> On 27/08/2013 05:55, Stephen Warren wrote: >>> On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: > On 08/24/2013 03:35 PM, Boris

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread boris brezillon
On 27/08/2013 09:42, Nicolas Ferre wrote: On 27/08/2013 08:16, boris brezillon : On 27/08/2013 05:55, Stephen Warren wrote: On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread Nicolas Ferre
On 27/08/2013 08:16, boris brezillon : On 27/08/2013 05:55, Stephen Warren wrote: On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread boris brezillon
On 27/08/2013 05:55, Stephen Warren wrote: On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter configuration. A deglitch filter works like a

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread boris brezillon
On 27/08/2013 05:55, Stephen Warren wrote: On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter configuration. A deglitch filter works like a

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread Nicolas Ferre
On 27/08/2013 08:16, boris brezillon : On 27/08/2013 05:55, Stephen Warren wrote: On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread boris brezillon
On 27/08/2013 09:42, Nicolas Ferre wrote: On 27/08/2013 08:16, boris brezillon : On 27/08/2013 05:55, Stephen Warren wrote: On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-27 Thread Stephen Warren
On 08/27/2013 01:42 AM, Nicolas Ferre wrote: On 27/08/2013 08:16, boris brezillon : On 27/08/2013 05:55, Stephen Warren wrote: On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-26 Thread Stephen Warren
On 08/26/2013 11:01 AM, boris brezillon wrote: > Hello Stephen, > > On 26/08/2013 18:50, Stephen Warren wrote: >> On 08/24/2013 03:35 PM, Boris BREZILLON wrote: >>> Add a new parameter to support deglitch filter configuration. >>> A deglitch filter works like a debounce filter but with a smaller

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-26 Thread boris brezillon
Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter configuration. A deglitch filter works like a debounce filter but with a smaller delay (nanoseconds). Why not use the existing debounce

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-26 Thread Stephen Warren
On 08/24/2013 03:35 PM, Boris BREZILLON wrote: > Add a new parameter to support deglitch filter configuration. > A deglitch filter works like a debounce filter but with a smaller > delay (nanoseconds). Why not use the existing debounce property, just with a small delay specified. It seems like

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-26 Thread Stephen Warren
On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter configuration. A deglitch filter works like a debounce filter but with a smaller delay (nanoseconds). Why not use the existing debounce property, just with a small delay specified. It seems like

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-26 Thread boris brezillon
Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter configuration. A deglitch filter works like a debounce filter but with a smaller delay (nanoseconds). Why not use the existing debounce

Re: [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-26 Thread Stephen Warren
On 08/26/2013 11:01 AM, boris brezillon wrote: Hello Stephen, On 26/08/2013 18:50, Stephen Warren wrote: On 08/24/2013 03:35 PM, Boris BREZILLON wrote: Add a new parameter to support deglitch filter configuration. A deglitch filter works like a debounce filter but with a smaller delay

[RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-24 Thread Boris BREZILLON
Add a new parameter to support deglitch filter configuration. A deglitch filter works like a debounce filter but with a smaller delay (nanoseconds). Signed-off-by: Boris BREZILLON --- .../bindings/pinctrl/pinctrl-bindings.txt |1 + drivers/pinctrl/pinconf-generic.c

[RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter

2013-08-24 Thread Boris BREZILLON
Add a new parameter to support deglitch filter configuration. A deglitch filter works like a debounce filter but with a smaller delay (nanoseconds). Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com --- .../bindings/pinctrl/pinctrl-bindings.txt |1 +