Re: [RFC PATCH 1/3] sched/fair: Aggregate task utilization only on root cfs_rq

2016-06-02 Thread Juri Lelli
On 02/06/16 16:53, Dietmar Eggemann wrote: > On 02/06/16 10:23, Juri Lelli wrote: > > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > >> index 218f8e83db73..212becd3708f 100644 > >> --- a/kernel/sched/fair.c > >> +++ b/kernel/sched/fair.c > >> @@ -2705,6 +2705,7 @@ __update_load_avg(u6

Re: [RFC PATCH 1/3] sched/fair: Aggregate task utilization only on root cfs_rq

2016-06-02 Thread Dietmar Eggemann
On 02/06/16 10:23, Juri Lelli wrote: >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 218f8e83db73..212becd3708f 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -2705,6 +2705,7 @@ __update_load_avg(u64 now, int cpu, struct sched_avg >> *sa, >> u32 con

Re: [RFC PATCH 1/3] sched/fair: Aggregate task utilization only on root cfs_rq

2016-06-02 Thread Juri Lelli
Hi, minor comment below. On 01/06/16 20:39, Dietmar Eggemann wrote: > cpu utilization (cpu_util()) is defined as the cpu (original) capacity > capped cfs_rq->avg->util_avg signal of the root cfs_rq. > > With the current pelt version, the utilization of a task [en|de]queued > on/from a cfs_rq, re

[RFC PATCH 1/3] sched/fair: Aggregate task utilization only on root cfs_rq

2016-06-01 Thread Dietmar Eggemann
cpu utilization (cpu_util()) is defined as the cpu (original) capacity capped cfs_rq->avg->util_avg signal of the root cfs_rq. With the current pelt version, the utilization of a task [en|de]queued on/from a cfs_rq, representing a task group other than the root task group on a cpu, is not immediat