Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-21 Thread Alan Cox
> --- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c > +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c > @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp > > /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; > 3DNow is IDd by bit 31 in extended CPUID (1*32+31)

Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-21 Thread Andi Kleen
On Saturday 21 April 2007 00:52:52 Chuck Ebbert wrote: > /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; >   3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ > -   clear_bit(0*32+31, >x86_capability); > +   clear_bit(X86_FEATURE_PBE, >x86_capability);

Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-21 Thread Dave Jones
On Fri, Apr 20, 2007 at 06:52:52PM -0400, Chuck Ebbert wrote: > --- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c > +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c > @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp > > /* Bit 31 in normal CPUID used for nonstandard 3DNow

Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-21 Thread Dave Jones
On Fri, Apr 20, 2007 at 06:52:52PM -0400, Chuck Ebbert wrote: --- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp /* Bit 31 in normal CPUID used for nonstandard 3DNow ID;

Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-21 Thread Andi Kleen
On Saturday 21 April 2007 00:52:52 Chuck Ebbert wrote: /* Bit 31 in normal CPUID used for nonstandard 3DNow ID;   3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ -   clear_bit(0*32+31, c-x86_capability); +   clear_bit(X86_FEATURE_PBE, c-x86_capability);   

Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-21 Thread Alan Cox
--- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway

[RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-20 Thread Chuck Ebbert
x86: use defined names for all CPU feature flags Don't use hard coded values for CPU flags. Signed-off-by: Chuck Ebbert <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/amd.c |2 +- arch/i386/kernel/cpu/centaur.c |2 +- arch/i386/kernel/cpu/cyrix.c|6 +++---

[RFC PATCH 1/3] x86: use defined names for all CPU feature flags

2007-04-20 Thread Chuck Ebbert
x86: use defined names for all CPU feature flags Don't use hard coded values for CPU flags. Signed-off-by: Chuck Ebbert [EMAIL PROTECTED] --- arch/i386/kernel/cpu/amd.c |2 +- arch/i386/kernel/cpu/centaur.c |2 +- arch/i386/kernel/cpu/cyrix.c|6 +++---