Re: [RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-18 Thread Jiri Kosina
On Mon, 9 Feb 2015, Josh Poimboeuf wrote: > If registering the function with ftrace has previously succeeded, > unregistering will almost never fail. Even if it does, it's not a fatal > error. We can still carry on and disable the klp_func from being used > by removing it from the klp_ops func

Re: [RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-18 Thread Petr Mladek
On Fri 2015-02-13 13:25:35, Miroslav Benes wrote: > On Mon, 9 Feb 2015, Josh Poimboeuf wrote: > > > If registering the function with ftrace has previously succeeded, > > unregistering will almost never fail. Even if it does, it's not a fatal > > error. We can still carry on and disable the

Re: [RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-18 Thread Petr Mladek
On Fri 2015-02-13 13:25:35, Miroslav Benes wrote: On Mon, 9 Feb 2015, Josh Poimboeuf wrote: If registering the function with ftrace has previously succeeded, unregistering will almost never fail. Even if it does, it's not a fatal error. We can still carry on and disable the klp_func

Re: [RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-18 Thread Jiri Kosina
On Mon, 9 Feb 2015, Josh Poimboeuf wrote: If registering the function with ftrace has previously succeeded, unregistering will almost never fail. Even if it does, it's not a fatal error. We can still carry on and disable the klp_func from being used by removing it from the klp_ops func

Re: [RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-13 Thread Miroslav Benes
On Mon, 9 Feb 2015, Josh Poimboeuf wrote: > If registering the function with ftrace has previously succeeded, > unregistering will almost never fail. Even if it does, it's not a fatal > error. We can still carry on and disable the klp_func from being used > by removing it from the klp_ops func

Re: [RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-13 Thread Miroslav Benes
On Mon, 9 Feb 2015, Josh Poimboeuf wrote: If registering the function with ftrace has previously succeeded, unregistering will almost never fail. Even if it does, it's not a fatal error. We can still carry on and disable the klp_func from being used by removing it from the klp_ops func

[RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-09 Thread Josh Poimboeuf
If registering the function with ftrace has previously succeeded, unregistering will almost never fail. Even if it does, it's not a fatal error. We can still carry on and disable the klp_func from being used by removing it from the klp_ops func stack. Signed-off-by: Josh Poimboeuf ---

[RFC PATCH 1/9] livepatch: simplify disable error path

2015-02-09 Thread Josh Poimboeuf
If registering the function with ftrace has previously succeeded, unregistering will almost never fail. Even if it does, it's not a fatal error. We can still carry on and disable the klp_func from being used by removing it from the klp_ops func stack. Signed-off-by: Josh Poimboeuf