Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-12-12 Thread Tetsuo Handa
On 2018/12/07 21:43, Tetsuo Handa wrote: > No response for one month. When can we get to an RCU stall problem syzbot > reported? Why not to apply this patch and then think how to address https://lore.kernel.org/lkml/201810100012.w9a0cjtn047...@www262.sakura.ne.jp/ ? >From 0fb58415770a83d6c40d471

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-12-07 Thread Tetsuo Handa
On 2018/11/07 19:08, Michal Hocko wrote: > On Wed 07-11-18 18:45:27, Tetsuo Handa wrote: >> On 2018/11/06 21:42, Michal Hocko wrote: >>> On Tue 06-11-18 18:44:43, Tetsuo Handa wrote: >>> [...] diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6e1469b..a97648a 100644 --- a/mm/memco

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 18:45:27, Tetsuo Handa wrote: > On 2018/11/06 21:42, Michal Hocko wrote: > > On Tue 06-11-18 18:44:43, Tetsuo Handa wrote: > > [...] > >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c > >> index 6e1469b..a97648a 100644 > >> --- a/mm/memcontrol.c > >> +++ b/mm/memcontrol.c > >> @@ -

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-11-07 Thread Tetsuo Handa
On 2018/11/06 21:42, Michal Hocko wrote: > On Tue 06-11-18 18:44:43, Tetsuo Handa wrote: > [...] >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 6e1469b..a97648a 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -1382,8 +1382,13 @@ static bool mem_cgroup_out_of_memory(struct

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-11-06 Thread Michal Hocko
On Tue 06-11-18 18:44:43, Tetsuo Handa wrote: [...] > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6e1469b..a97648a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1382,8 +1382,13 @@ static bool mem_cgroup_out_of_memory(struct mem_cgroup > *memcg, gfp_t gfp_mask, > };

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-11-06 Thread Tetsuo Handa
>From dc0d9ec3205a28680dcf2213c0ffe8820e8b5913 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Tue, 6 Nov 2018 12:27:36 +0900 Subject: [PATCH] memcg: killed threads should not invoke memcg OOM killer It is possible that a single process group memcg easily swamps the log with no-eligible OOM vic

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-26 Thread Tetsuo Handa
On 2018/10/27 4:25, Michal Hocko wrote: >> out_of_memory() bails on task_will_free_mem(current), which >> specifically *excludes* already reaped tasks. Why are we then adding a >> separate check before that to bail on already reaped victims? > > 696453e66630a has introduced the bail out. > >> Do

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-26 Thread Michal Hocko
On Fri 26-10-18 21:25:51, Michal Hocko wrote: > On Fri 26-10-18 10:25:31, Johannes Weiner wrote: [...] > > There is of course the scenario brought forward in this thread, where > > multiple threads of a process race and the second one enters oom even > > though it doesn't need to anymore. What the

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-26 Thread Michal Hocko
On Fri 26-10-18 10:25:31, Johannes Weiner wrote: > On Mon, Oct 22, 2018 at 09:13:23AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > Tetsuo has reported [1] that a single process group memcg might easily > > swamp the log with no-eligible oom victim reports due to race between > > the

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-26 Thread Johannes Weiner
On Mon, Oct 22, 2018 at 09:13:23AM +0200, Michal Hocko wrote: > From: Michal Hocko > > Tetsuo has reported [1] that a single process group memcg might easily > swamp the log with no-eligible oom victim reports due to race between > the memcg charge and oom_reaper > > Thread 1 Thread

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-23 Thread Michal Hocko
On Tue 23-10-18 21:33:43, Tetsuo Handa wrote: > On 2018/10/23 21:10, Michal Hocko wrote: > > On Tue 23-10-18 13:42:46, Michal Hocko wrote: > >> On Tue 23-10-18 10:01:08, Tetsuo Handa wrote: > >>> Michal Hocko wrote: > On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: > >> diff --git a/mm/memco

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-23 Thread Tetsuo Handa
On 2018/10/23 21:10, Michal Hocko wrote: > On Tue 23-10-18 13:42:46, Michal Hocko wrote: >> On Tue 23-10-18 10:01:08, Tetsuo Handa wrote: >>> Michal Hocko wrote: On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index e79cb59552d9..a9dfe

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-23 Thread Michal Hocko
On Tue 23-10-18 13:42:46, Michal Hocko wrote: > On Tue 23-10-18 10:01:08, Tetsuo Handa wrote: > > Michal Hocko wrote: > > > On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: > > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > > > index e79cb59552d9..a9dfed29967b 100644 > > > > > --- a/mm/mem

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-23 Thread Michal Hocko
On Tue 23-10-18 10:01:08, Tetsuo Handa wrote: > Michal Hocko wrote: > > On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > > index e79cb59552d9..a9dfed29967b 100644 > > > > --- a/mm/memcontrol.c > > > > +++ b/mm/memcontrol.c > > > > @@ -1380,1

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-22 Thread Tetsuo Handa
Michal Hocko wrote: > On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index e79cb59552d9..a9dfed29967b 100644 > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -1380,10 +1380,22 @@ static bool mem_cgroup_out_of_memory(struct >

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-22 Thread Tetsuo Handa
On 2018/10/22 22:43, Michal Hocko wrote: > On Mon 22-10-18 22:20:36, Tetsuo Handa wrote: >> I mean: >> >> mm/memcontrol.c | 3 +- >> mm/oom_kill.c | 111 >> +--- >> 2 files changed, 12 insertions(+), 102 deletions(-) > > This is much larger

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-22 Thread Michal Hocko
On Mon 22-10-18 22:20:36, Tetsuo Handa wrote: > On 2018/10/22 21:03, Michal Hocko wrote: > > On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: > >> On 2018/10/22 16:13, Michal Hocko wrote: > >>> From: Michal Hocko > >>> > >>> Tetsuo has reported [1] that a single process group memcg might easily > >>>

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-22 Thread Tetsuo Handa
On 2018/10/22 21:03, Michal Hocko wrote: > On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: >> On 2018/10/22 16:13, Michal Hocko wrote: >>> From: Michal Hocko >>> >>> Tetsuo has reported [1] that a single process group memcg might easily >>> swamp the log with no-eligible oom victim reports due to ra

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-22 Thread Michal Hocko
On Mon 22-10-18 20:45:17, Tetsuo Handa wrote: > On 2018/10/22 16:13, Michal Hocko wrote: > > From: Michal Hocko > > > > Tetsuo has reported [1] that a single process group memcg might easily > > swamp the log with no-eligible oom victim reports due to race between > > the memcg charge and oom_rea

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-22 Thread Tetsuo Handa
On 2018/10/22 16:13, Michal Hocko wrote: > From: Michal Hocko > > Tetsuo has reported [1] that a single process group memcg might easily > swamp the log with no-eligible oom victim reports due to race between > the memcg charge and oom_reaper > > Thread 1 Thread2

[RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-22 Thread Michal Hocko
From: Michal Hocko Tetsuo has reported [1] that a single process group memcg might easily swamp the log with no-eligible oom victim reports due to race between the memcg charge and oom_reaper Thread 1Thread2 oom_reaper try_charge try_charge