Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-06-06 Thread Sören Brinkmann
On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: > Hello Sören, > > On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: > > On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: > > > Quoting Uwe Kleine-König (2014-05-21 11:23:08) > > > > Hello Sören, > > > > > > >

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-06-06 Thread Sören Brinkmann
On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: Hello Sören, On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: Quoting Uwe Kleine-König (2014-05-21 11:23:08) Hello Sören, On Wed, May 21,

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-28 Thread Rafael J. Wysocki
On Tuesday, May 27, 2014 07:05:31 PM Mike Turquette wrote: > Quoting Rafael J. Wysocki (2014-05-26 04:22:32) > > On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: > > > On 23 May 2014 21:44, Sören Brinkmann wrote: > > > > Viresh: Could you imagine something similar for cpufreq? You

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-28 Thread Rafael J. Wysocki
On Tuesday, May 27, 2014 07:05:31 PM Mike Turquette wrote: Quoting Rafael J. Wysocki (2014-05-26 04:22:32) On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: On 23 May 2014 21:44, Sören Brinkmann soren.brinkm...@xilinx.com wrote: Viresh: Could you imagine something similar for

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-27 Thread Mike Turquette
Quoting Rafael J. Wysocki (2014-05-26 04:22:32) > On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: > > On 23 May 2014 21:44, Sören Brinkmann wrote: > > > Viresh: Could you imagine something similar for cpufreq? You suggested > > > migrating to Hz resolution. I guess that would ideally mean

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-27 Thread Mike Turquette
Quoting Rafael J. Wysocki (2014-05-26 04:22:32) On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: On 23 May 2014 21:44, Sören Brinkmann soren.brinkm...@xilinx.com wrote: Viresh: Could you imagine something similar for cpufreq? You suggested migrating to Hz resolution. I guess that

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Sören Brinkmann
On Mon, 2014-05-26 at 01:47PM +0200, Rafael J. Wysocki wrote: > On Monday, May 26, 2014 04:37:13 PM Viresh Kumar wrote: > > On 26 May 2014 16:52, Rafael J. Wysocki wrote: > > > I agree as far as the 64-bit thing goes, but is switching to Hz really > > > necessary? > > > > Don't really know

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Rafael J. Wysocki
On Monday, May 26, 2014 04:37:13 PM Viresh Kumar wrote: > On 26 May 2014 16:52, Rafael J. Wysocki wrote: > > I agree as far as the 64-bit thing goes, but is switching to Hz really > > necessary? > > Don't really know that.. It seems that there will always be problems with > close enough

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Viresh Kumar
On 26 May 2014 16:52, Rafael J. Wysocki wrote: > I agree as far as the 64-bit thing goes, but is switching to Hz really > necessary? Don't really know that.. It seems that there will always be problems with close enough frequencies whenever rounding is done. More can be elaborated by Soren. --

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Rafael J. Wysocki
On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: > On 23 May 2014 21:44, Sören Brinkmann wrote: > > Viresh: Could you imagine something similar for cpufreq? You suggested > > migrating to Hz resolution. I guess that would ideally mean to follow > > the CCF to a 64-bit type for frequencies

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Viresh Kumar
On 23 May 2014 21:44, Sören Brinkmann wrote: > Viresh: Could you imagine something similar for cpufreq? You suggested > migrating to Hz resolution. I guess that would ideally mean to follow > the CCF to a 64-bit type for frequencies and increasing the resolution. > I have a messy patch migrating

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Viresh Kumar
On 23 May 2014 21:44, Sören Brinkmann soren.brinkm...@xilinx.com wrote: Viresh: Could you imagine something similar for cpufreq? You suggested migrating to Hz resolution. I guess that would ideally mean to follow the CCF to a 64-bit type for frequencies and increasing the resolution. I have a

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Rafael J. Wysocki
On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: On 23 May 2014 21:44, Sören Brinkmann soren.brinkm...@xilinx.com wrote: Viresh: Could you imagine something similar for cpufreq? You suggested migrating to Hz resolution. I guess that would ideally mean to follow the CCF to a 64-bit

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Viresh Kumar
On 26 May 2014 16:52, Rafael J. Wysocki r...@rjwysocki.net wrote: I agree as far as the 64-bit thing goes, but is switching to Hz really necessary? Don't really know that.. It seems that there will always be problems with close enough frequencies whenever rounding is done. More can be

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Rafael J. Wysocki
On Monday, May 26, 2014 04:37:13 PM Viresh Kumar wrote: On 26 May 2014 16:52, Rafael J. Wysocki r...@rjwysocki.net wrote: I agree as far as the 64-bit thing goes, but is switching to Hz really necessary? Don't really know that.. It seems that there will always be problems with close

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-26 Thread Sören Brinkmann
On Mon, 2014-05-26 at 01:47PM +0200, Rafael J. Wysocki wrote: On Monday, May 26, 2014 04:37:13 PM Viresh Kumar wrote: On 26 May 2014 16:52, Rafael J. Wysocki r...@rjwysocki.net wrote: I agree as far as the 64-bit thing goes, but is switching to Hz really necessary? Don't really know

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-23 Thread Sören Brinkmann
On Thu, 2014-05-22 at 06:37PM -0700, Mike Turquette wrote: > Quoting Sören Brinkmann (2014-05-22 16:44:53) > > On Thu, 2014-05-22 at 02:03PM -0700, Mike Turquette wrote: > > > Quoting Sören Brinkmann (2014-05-22 13:32:09) > > > > On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: > > > >

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-23 Thread Sören Brinkmann
On Thu, 2014-05-22 at 06:37PM -0700, Mike Turquette wrote: Quoting Sören Brinkmann (2014-05-22 16:44:53) On Thu, 2014-05-22 at 02:03PM -0700, Mike Turquette wrote: Quoting Sören Brinkmann (2014-05-22 13:32:09) On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: Hello Sören,

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Sören Brinkmann
On Thu, 2014-05-22 at 02:03PM -0700, Mike Turquette wrote: > Quoting Sören Brinkmann (2014-05-22 13:32:09) > > On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: > > > Hello Sören, > > > > > > On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: > > > > On Wed, 2014-05-21 at

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Mike Turquette
Quoting Sören Brinkmann (2014-05-22 13:32:09) > On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: > > Hello Sören, > > > > On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: > > > On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: > > > > Quoting Uwe Kleine-König

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Sören Brinkmann
On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: > Hello Sören, > > On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: > > On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: > > > Quoting Uwe Kleine-König (2014-05-21 11:23:08) > > > > Hello Sören, > > > > > > >

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Uwe Kleine-König
Hello Sören, On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: > On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: > > Quoting Uwe Kleine-König (2014-05-21 11:23:08) > > > Hello Sören, > > > > > > On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: > > > > On

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Sören Brinkmann
On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: > Quoting Uwe Kleine-König (2014-05-21 11:23:08) > > Hello Sören, > > > > On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: > > > On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: > > > > On Tue, May 20, 2014 at

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Sören Brinkmann
On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: Quoting Uwe Kleine-König (2014-05-21 11:23:08) Hello Sören, On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: On Tue, May 20, 2014 at 02:48:20PM

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Uwe Kleine-König
Hello Sören, On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: Quoting Uwe Kleine-König (2014-05-21 11:23:08) Hello Sören, On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Sören Brinkmann
On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: Hello Sören, On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: Quoting Uwe Kleine-König (2014-05-21 11:23:08) Hello Sören, On Wed, May 21,

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Mike Turquette
Quoting Sören Brinkmann (2014-05-22 13:32:09) On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: Hello Sören, On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 01:33PM -0700, Mike Turquette wrote: Quoting Uwe Kleine-König (2014-05-21

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-22 Thread Sören Brinkmann
On Thu, 2014-05-22 at 02:03PM -0700, Mike Turquette wrote: Quoting Sören Brinkmann (2014-05-22 13:32:09) On Thu, 2014-05-22 at 08:20PM +0200, Uwe Kleine-König wrote: Hello Sören, On Thu, May 22, 2014 at 11:03:00AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 01:33PM -0700,

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Mike Turquette
Quoting Uwe Kleine-König (2014-05-21 11:23:08) > Hello Sören, > > On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: > > On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: > > > On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: > > > > On Tue, 2014-05-20 at

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Sören Brinkmann
On Wed, 2014-05-21 at 08:23PM +0200, Uwe Kleine-König wrote: > Hello Sören, > > On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: > > On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: > > > On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: > > > > On Tue,

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Uwe Kleine-König
Hello Sören, On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: > On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: > > On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: > > > On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: > > > > On 05/20/14

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Sören Brinkmann
On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: > Hello, > > On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: > > On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: > > > On 05/20/14 09:01, Sören Brinkmann wrote: > > > > > > > > +{ > > > > + unsigned

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Uwe Kleine-König
Hello, On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: > On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: > > On 05/20/14 09:01, Sören Brinkmann wrote: > > > > > > +{ > > > + unsigned long lower, upper, cur, lower_last, upper_last; > > > + > > > +

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Uwe Kleine-König
Hello, On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: On 05/20/14 09:01, Sören Brinkmann wrote: +{ + unsigned long lower, upper, cur, lower_last, upper_last; + + lower = clk_round_rate(clk, rate);

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Sören Brinkmann
On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: Hello, On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: On 05/20/14 09:01, Sören Brinkmann wrote: +{ + unsigned long lower, upper, cur,

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Uwe Kleine-König
Hello Sören, On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: On 05/20/14 09:01, Sören

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Sören Brinkmann
On Wed, 2014-05-21 at 08:23PM +0200, Uwe Kleine-König wrote: Hello Sören, On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: On Tue, 2014-05-20

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-21 Thread Mike Turquette
Quoting Uwe Kleine-König (2014-05-21 11:23:08) Hello Sören, On Wed, May 21, 2014 at 08:58:10AM -0700, Sören Brinkmann wrote: On Wed, 2014-05-21 at 09:34AM +0200, Uwe Kleine-König wrote: On Tue, May 20, 2014 at 02:48:20PM -0700, Sören Brinkmann wrote: On Tue, 2014-05-20 at 10:48AM

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Sören Brinkmann
On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: > On 05/20/14 09:01, Sören Brinkmann wrote: > > > > +{ > > + unsigned long lower, upper, cur, lower_last, upper_last; > > + > > + lower = clk_round_rate(clk, rate); > > + if (lower >= rate) > > +

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Stephen Boyd
On 05/20/14 09:01, Sören Brinkmann wrote: > > +{ > + unsigned long lower, upper, cur, lower_last, upper_last; > + > + lower = clk_round_rate(clk, rate); > + if (lower >= rate) > + return lower; Is the >-case worth a warning? >>> No, it's correct behavior. If

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Sören Brinkmann
Hi Uwe, On Tue, 2014-05-20 at 09:33AM +0200, Uwe Kleine-König wrote: > Hi Sören, > > On Mon, May 19, 2014 at 09:41:32AM -0700, Sören Brinkmann wrote: > > On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: > > > Hi Sören, > > > > > > On Sun, May 18, 2014 at 05:51:05PM -0700, Sören

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Uwe Kleine-König
Hello, On Mon, May 19, 2014 at 10:29:05AM -0700, Sören Brinkmann wrote: > With the improvements suggested by you I have this now: > > long clk_round_rate_nearest(struct clk *clk, unsigned long rate) > { > unsigned long lower, upper; > > lower = clk_round_rate(clk, rate); > if

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Uwe Kleine-König
Hi Sören, On Mon, May 19, 2014 at 09:41:32AM -0700, Sören Brinkmann wrote: > On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: > > Hi Sören, > > > > On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote: > > >

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Uwe Kleine-König
Hi Sören, On Mon, May 19, 2014 at 09:41:32AM -0700, Sören Brinkmann wrote: On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: Hi Sören, On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote:

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Uwe Kleine-König
Hello, On Mon, May 19, 2014 at 10:29:05AM -0700, Sören Brinkmann wrote: With the improvements suggested by you I have this now: long clk_round_rate_nearest(struct clk *clk, unsigned long rate) { unsigned long lower, upper; lower = clk_round_rate(clk, rate); if (lower =

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Sören Brinkmann
Hi Uwe, On Tue, 2014-05-20 at 09:33AM +0200, Uwe Kleine-König wrote: Hi Sören, On Mon, May 19, 2014 at 09:41:32AM -0700, Sören Brinkmann wrote: On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: Hi Sören, On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote:

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Stephen Boyd
On 05/20/14 09:01, Sören Brinkmann wrote: +{ + unsigned long lower, upper, cur, lower_last, upper_last; + + lower = clk_round_rate(clk, rate); + if (lower = rate) + return lower; Is the -case worth a warning? No, it's correct behavior. If you request a rate that is way lower than

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-20 Thread Sören Brinkmann
On Tue, 2014-05-20 at 10:48AM -0700, Stephen Boyd wrote: On 05/20/14 09:01, Sören Brinkmann wrote: +{ + unsigned long lower, upper, cur, lower_last, upper_last; + + lower = clk_round_rate(clk, rate); + if (lower = rate) + return lower; Is the -case

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-19 Thread Sören Brinkmann
Hi Uwe, On Mon, 2014-05-19 at 09:41AM -0700, Sören Brinkmann wrote: > On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: > > Hi Sören, > > > > On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote: > > >

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-19 Thread Sören Brinkmann
On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: > Hi Sören, > > On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote: > > --8<-8<-8<-8<--- > > From: Soren Brinkmann > > Date: Tue, 2 Apr 2013 10:08:13 -0700 >

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-19 Thread Uwe Kleine-König
Hi Sören, On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote: > --8<-8<-8<-8<--- > From: Soren Brinkmann > Date: Tue, 2 Apr 2013 10:08:13 -0700 > Subject: [PATCH] clk: Introduce 'clk_round_rate_nearest()' > > Introduce

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-19 Thread Uwe Kleine-König
Hi Sören, On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote: --8-8-8-8--- From: Soren Brinkmann soren.brinkm...@xilinx.com Date: Tue, 2 Apr 2013 10:08:13 -0700 Subject: [PATCH] clk: Introduce

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-19 Thread Sören Brinkmann
On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: Hi Sören, On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote: --8-8-8-8--- From: Soren Brinkmann soren.brinkm...@xilinx.com Date: Tue, 2 Apr 2013

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-19 Thread Sören Brinkmann
Hi Uwe, On Mon, 2014-05-19 at 09:41AM -0700, Sören Brinkmann wrote: On Mon, 2014-05-19 at 06:19PM +0200, Uwe Kleine-König wrote: Hi Sören, On Sun, May 18, 2014 at 05:51:05PM -0700, Sören Brinkmann wrote: --8-8-8-8---

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-18 Thread Sören Brinkmann
Hi, I spent some time finding an alternative implementation for clk_round_rate_nearest, the result can be found below. I hope this is closer to a working implementation. Thanks, Sören --8<-8<-8<-8<--- From: Soren

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-18 Thread Sören Brinkmann
Hi, I spent some time finding an alternative implementation for clk_round_rate_nearest, the result can be found below. I hope this is closer to a working implementation. Thanks, Sören --8-8-8-8--- From: Soren

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-15 Thread Sören Brinkmann
Hi Uwe, On Thu, 2014-05-15 at 09:38AM +0200, Uwe Kleine-König wrote: > Hello, > > it's great you pick that up. > > On Wed, May 14, 2014 at 03:30:52PM -0700, Soren Brinkmann wrote: > > Introduce a new API function to round a rate to the closest possible > > rate the HW clock can generate. > > In

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-15 Thread Uwe Kleine-König
Hello, it's great you pick that up. On Wed, May 14, 2014 at 03:30:52PM -0700, Soren Brinkmann wrote: > Introduce a new API function to round a rate to the closest possible > rate the HW clock can generate. > In contrast to 'clk_round_rate()' which works similar, but always returns > a frequency

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-15 Thread Uwe Kleine-König
Hello, it's great you pick that up. On Wed, May 14, 2014 at 03:30:52PM -0700, Soren Brinkmann wrote: Introduce a new API function to round a rate to the closest possible rate the HW clock can generate. In contrast to 'clk_round_rate()' which works similar, but always returns a frequency =

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-15 Thread Sören Brinkmann
Hi Uwe, On Thu, 2014-05-15 at 09:38AM +0200, Uwe Kleine-König wrote: Hello, it's great you pick that up. On Wed, May 14, 2014 at 03:30:52PM -0700, Soren Brinkmann wrote: Introduce a new API function to round a rate to the closest possible rate the HW clock can generate. In contrast

[RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-14 Thread Soren Brinkmann
Introduce a new API function to round a rate to the closest possible rate the HW clock can generate. In contrast to 'clk_round_rate()' which works similar, but always returns a frequency <= its input rate. The code comes from Uwe and was copied from this LKML thread:

[RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-14 Thread Soren Brinkmann
Introduce a new API function to round a rate to the closest possible rate the HW clock can generate. In contrast to 'clk_round_rate()' which works similar, but always returns a frequency = its input rate. The code comes from Uwe and was copied from this LKML thread: