Re: [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY

On 06/06/2016 11:27 PM, Hillf Danton wrote: >> @@ -182,6 +354,13 @@ retry: >> goto out_unlock; >> >> /* >> + * If this is a HUGETLB vma, pass off to appropriate routine >> + */ >> +if (dst_vma->vm_flags & VM_HUGETLB) > > Use is_vm_hugetlb_page()? > And in cases in

Re: [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY

On 06/06/2016 11:27 PM, Hillf Danton wrote: >> @@ -182,6 +354,13 @@ retry: >> goto out_unlock; >> >> /* >> + * If this is a HUGETLB vma, pass off to appropriate routine >> + */ >> +if (dst_vma->vm_flags & VM_HUGETLB) > > Use is_vm_hugetlb_page()? > And in cases in

Re: [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY

> @@ -182,6 +354,13 @@ retry: > goto out_unlock; > > /* > + * If this is a HUGETLB vma, pass off to appropriate routine > + */ > + if (dst_vma->vm_flags & VM_HUGETLB) Use is_vm_hugetlb_page()? And in cases in subsequent patches? Hillf > + return

Re: [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY

> @@ -182,6 +354,13 @@ retry: > goto out_unlock; > > /* > + * If this is a HUGETLB vma, pass off to appropriate routine > + */ > + if (dst_vma->vm_flags & VM_HUGETLB) Use is_vm_hugetlb_page()? And in cases in subsequent patches? Hillf > + return

[RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY

__mcopy_atomic_hugetlb performs the UFFDIO_COPY operation for huge pages. It is based on the existing __mcopy_atomic routine for normal pages. Unlike normal pages, there is no huge page support for the UFFDIO_ZEROPAGE operation. Signed-off-by: Mike Kravetz ---

[RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY

__mcopy_atomic_hugetlb performs the UFFDIO_COPY operation for huge pages. It is based on the existing __mcopy_atomic routine for normal pages. Unlike normal pages, there is no huge page support for the UFFDIO_ZEROPAGE operation. Signed-off-by: Mike Kravetz --- mm/userfaultfd.c | 179