Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-09-04 Thread Wolfram Sang
Hi Codrin, > The pinmux driver needs to have strict set to false, otherwise the > switching is not available, not at this time at least. Perhaps there is > room for improvement here, because the I2C bus is not using the pins > while we are doing GPIO recovery. Our driver doesn't use 'strict'.

Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-09-04 Thread Codrin.Ciubotariu
On 26.08.2020 09:14, Wolfram Sang wrote: > >> Thanks, this would be great! I tested this on a sam9x60, with the HW >> feature for the 9 pulses disabled, with a picky audio codec as I2C device. >> Please let me know of the result. > > I can't make use of the feature on the platform I had in mind,

Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-08-26 Thread Wolfram Sang
> Thanks, this would be great! I tested this on a sam9x60, with the HW > feature for the 9 pulses disabled, with a picky audio codec as I2C device. > Please let me know of the result. I can't make use of the feature on the platform I had in mind, sadly. It doesn't really support switching

Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-08-03 Thread wsa
> > Nice diffstat! I will try using this new functionality with another > > controller next week. > > > > Thanks, this would be great! I tested this on a sam9x60, with the HW > feature for the 9 pulses disabled, with a picky audio codec as I2C device. > Please let me know of the result. I'll

Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-08-03 Thread Codrin.Ciubotariu
On 02.08.2020 20:08, Wolfram Sang wrote: > On Fri, Jun 19, 2020 at 05:19:04PM +0300, Codrin Ciubotariu wrote: >> Make the Microchip at91 driver the first to use the generic GPIO bus >> recovery support from the I2C core and discard the driver implementation. >> >> Signed-off-by: Codrin Ciubotariu

Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-08-02 Thread Wolfram Sang
On Fri, Jun 19, 2020 at 05:19:04PM +0300, Codrin Ciubotariu wrote: > Make the Microchip at91 driver the first to use the generic GPIO bus > recovery support from the I2C core and discard the driver implementation. > > Signed-off-by: Codrin Ciubotariu > --- > drivers/i2c/busses/i2c-at91-master.c

[RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-06-19 Thread Codrin Ciubotariu
Make the Microchip at91 driver the first to use the generic GPIO bus recovery support from the I2C core and discard the driver implementation. Signed-off-by: Codrin Ciubotariu --- drivers/i2c/busses/i2c-at91-master.c | 69 ++-- drivers/i2c/busses/i2c-at91.h| 3