Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-12 Thread Jiri Pirko
Wed, Dec 13, 2017 at 12:54:39AM CET, mkube...@suse.cz wrote: >On Mon, Dec 11, 2017 at 05:16:01PM +0100, Jiri Pirko wrote: >> Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: >> >+ >> >+ETHA_DRVINFO_DRIVER(string)driver name >> >+ETHA_DRVINFO_VERSION

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-12 Thread Jiri Pirko
Wed, Dec 13, 2017 at 12:54:39AM CET, mkube...@suse.cz wrote: >On Mon, Dec 11, 2017 at 05:16:01PM +0100, Jiri Pirko wrote: >> Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: >> >+ >> >+ETHA_DRVINFO_DRIVER(string)driver name >> >+ETHA_DRVINFO_VERSION

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-12 Thread Michal Kubecek
On Mon, Dec 11, 2017 at 05:16:01PM +0100, Jiri Pirko wrote: > Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: > >+ > >+ETHA_DRVINFO_DRIVER (string)driver name > >+ETHA_DRVINFO_VERSION(string)driver version > > You use 3 prefixes: > ETHTOOL_ for

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-12 Thread Michal Kubecek
On Mon, Dec 11, 2017 at 05:16:01PM +0100, Jiri Pirko wrote: > Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: > >+ > >+ETHA_DRVINFO_DRIVER (string)driver name > >+ETHA_DRVINFO_VERSION(string)driver version > > You use 3 prefixes: > ETHTOOL_ for

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-11 Thread Jiri Pirko
Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: >Request the same information as ETHTOOL_GDRVINFO. This is read-only so that >corresponding SET_DRVINFO exists but is only used in kernel replies. Rip >the code to query the driver out of the legacy interface and move it to >a new file

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-11 Thread Jiri Pirko
Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: >Request the same information as ETHTOOL_GDRVINFO. This is read-only so that >corresponding SET_DRVINFO exists but is only used in kernel replies. Rip >the code to query the driver out of the legacy interface and move it to >a new file

[RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-11 Thread Michal Kubecek
Request the same information as ETHTOOL_GDRVINFO. This is read-only so that corresponding SET_DRVINFO exists but is only used in kernel replies. Rip the code to query the driver out of the legacy interface and move it to a new file ethtool_common.c so that both interfaces can use it.

[RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-11 Thread Michal Kubecek
Request the same information as ETHTOOL_GDRVINFO. This is read-only so that corresponding SET_DRVINFO exists but is only used in kernel replies. Rip the code to query the driver out of the legacy interface and move it to a new file ethtool_common.c so that both interfaces can use it.