Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-06-03 Thread Mateusz Guzik
On Mon, Apr 13, 2015 at 11:39:01AM +1000, James Morris wrote: > On Wed, 8 Apr 2015, Mateusz Guzik wrote: > > > This is still a problem. Any feedback about the patch? > > > > I'd like to see feedback from vfs folk (Al). > Ping? Are there any concerns with the patch? -- Mateusz Guzik -- To uns

Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-04-12 Thread James Morris
On Wed, 8 Apr 2015, Mateusz Guzik wrote: > This is still a problem. Any feedback about the patch? > I'd like to see feedback from vfs folk (Al). -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-04-08 Thread Mateusz Guzik
On Sat, Jan 17, 2015 at 11:26:46PM +, Ben Hutchings wrote: > chown() and write() should clear all privilege attributes on > a file - setuid, setgid, setcap and any other extended > privilege attributes. > > However, any attributes beyond setuid and setgid are managed by the > LSM and not direc

Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-02-16 Thread Josh Boyer
On Sat, Jan 17, 2015 at 6:26 PM, Ben Hutchings wrote: > chown() and write() should clear all privilege attributes on > a file - setuid, setgid, setcap and any other extended > privilege attributes. > > However, any attributes beyond setuid and setgid are managed by the > LSM and not directly by th

Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-01-21 Thread Casey Schaufler
On 1/21/2015 6:03 AM, Stephen Smalley wrote: > On 01/20/2015 06:17 PM, James Morris wrote: >> On Sat, 17 Jan 2015, Ben Hutchings wrote: >> >>> chown() and write() should clear all privilege attributes on >>> a file - setuid, setgid, setcap and any other extended >>> privilege attributes. >>> >>> Ho

Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-01-21 Thread Stephen Smalley
On 01/20/2015 06:17 PM, James Morris wrote: > On Sat, 17 Jan 2015, Ben Hutchings wrote: > >> chown() and write() should clear all privilege attributes on >> a file - setuid, setgid, setcap and any other extended >> privilege attributes. >> >> However, any attributes beyond setuid and setgid are ma

Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-01-20 Thread Casey Schaufler
On 1/20/2015 3:17 PM, James Morris wrote: > On Sat, 17 Jan 2015, Ben Hutchings wrote: > >> chown() and write() should clear all privilege attributes on >> a file - setuid, setgid, setcap and any other extended >> privilege attributes. >> >> However, any attributes beyond setuid and setgid are manag

Re: [RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-01-20 Thread James Morris
On Sat, 17 Jan 2015, Ben Hutchings wrote: > chown() and write() should clear all privilege attributes on > a file - setuid, setgid, setcap and any other extended > privilege attributes. > > However, any attributes beyond setuid and setgid are managed by the > LSM and not directly by the filesyste

[RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-01-17 Thread Ben Hutchings
chown() and write() should clear all privilege attributes on a file - setuid, setgid, setcap and any other extended privilege attributes. However, any attributes beyond setuid and setgid are managed by the LSM and not directly by the filesystem, so they cannot be set along with the other attribute